-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics from VICI client #8
Conversation
This is pretty cool 👍 💯 |
This reduces the overhead of all methods requesting an API has to converts its payload up front.
Catched by staticcheck ./...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Had a bit hard time of getting a full overview of the code, but it seems pretty solid 👍
I've added my proposals for the buckets
I've not set any of all the labels we discussed @emilingerslev . And I've removed the notes we made when discussing it, so maybe we should give it another try? |
Alright, so yeah maybe we should go over the labels again. From the top of my head I got for Child SA's
For IKE SA's (and the Child SA's below):
|
I'll add that. Then we can get it merged and out and running. Then we can add new labels later on. |
I've added labels. An example metric is now like this.
|
@emilingerslev ready for another review of the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 lets merge this! 💪
Great. I'll work on a good commit message :D |
This change introduces prometheus metrics from a strongswan process.
It collects statistics by inspecting the results of
swanctl --list-conn
andswanctl --list-sas
calls.Package
vici
is ported from https://github.com/bronze1man/goStrongswanVici and updated with error handling and removal offmt.Print
calls.Package
strongswan
implements the actually collection of data and reports to thePrometheusReporter
instance.