Implement {Option,Result}.unwrapOrElse #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something I re-discovered as missing yesterday, we can definitely use this in some places. The quivalent of Rust's unwrap_or_else.
jstasiak
requested review from
a team,
rbruggem,
raguiar9080,
charcarr,
0bex0 and
jasharifestina
raguiar9080
approved these changes
Jul 4, 2024
docs/reference/api/option.rst
Outdated
|
|
||
| Returns the contained ``Some`` value or computes a value with a provided function. | ||
|
|
||
| The function is at most one time, only if needed. |
There was a problem hiding this comment.
Feels like a word missing here: is at most one time
docs/reference/api/result.rst
Outdated
| (error) => { console.log(`Called, got ${error}`); return 'UGH'; } | ||
| ) // => 'OK', nothing printed | ||
|
|
||
| Err('A03B').unwrapOrElse((error) => `UGH, got ${error}') // => 'UGH, got A03B' |
There was a problem hiding this comment.
I think the backward quotes are not being correctly closed here, I don't see it and GH also shows that they don't get closed.
There was a problem hiding this comment.
You have a keen eye, fixing
|
Hello - this does not appear to be included in the latest 4.2.0 release. Will there be a new release soon? |
|
Hey, yeah not released yet, do you need it? I can expedite that if so. |
Wow. So why it is mentioned in docs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I re-discovered as missing yesterday, we can definitely use this in some places.
The equivalent of Rust's unwrap_or_else.