-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a Non-Blocking Child Process Interface #211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename success key in table to be "ok", so that it is consistent with process.exec.
…t other way around
The PR is pretty much ready for review minus the windows test failing (due to the message not being written to stderr, hence the reader yielding). |
filiptibell
requested changes
Jun 23, 2024
Co-authored-by: Filip Tibell <filip.tibell@gmail.com>
Almost89
reviewed
Jun 29, 2024
Almost89
reviewed
Jun 29, 2024
filiptibell
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design
As proposed previously, instead of using raw streams or events which tend to get complex or don't fit well within Luau, this design uses simple readers and writers for different streams which can be used at will.
Closes #200 and closes #131.