Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bonding/Unbonding #133

Closed
2 tasks
faboweb opened this issue Nov 28, 2017 · 6 comments
Closed
2 tasks

Bonding/Unbonding #133

faboweb opened this issue Nov 28, 2017 · 6 comments
Assignees
Labels
design-work-needed 🎨 issues that require design work before development

Comments

@faboweb
Copy link
Collaborator

faboweb commented Nov 28, 2017

I as a user
want to bond/unbond atoms off a selected validator
so that I can participate in securing the network.

AC:

  • user can bond atoms to a validator
  • user can unbond atoms off a validator
@faboweb faboweb mentioned this issue Nov 28, 2017
13 tasks
@jbibla jbibla added the design-work-needed 🎨 issues that require design work before development label Nov 28, 2017
@nylira
Copy link
Contributor

nylira commented Nov 30, 2017

I'll help get the design portion of this running again (tomorrow).

@faboweb faboweb self-assigned this Dec 12, 2017
@faboweb
Copy link
Collaborator Author

faboweb commented Dec 19, 2017

@nylira @jolesbi: Is the design part of unbonding done? What is the flow for unbdonding.

I see that this is somehow included in the bonding process.
To clarify:
The expected process is: Candidates you have bond with are in your 'shoppingCart'. Clicking on the 'checkmark' at the candidates page will bring you to the PageBond where you see the bonded candidates (+ candidates you have selected). Then you can assign Atoms to all the candidates as you whish.

@mappum
Copy link
Contributor

mappum commented Dec 19, 2017

What is the flow for unbdonding.

IMO it should be like this:

  1. The user bonds some atoms like you described
  2. Now, in their Delegates menu, we show their current bonds (even if they restarted the app, since we can fetch the data from gaia). Validators currently bonded to can't be deselected.
  3. If they go through to the PageBond again, they can now edit their bond allocation, and if any currently bonded validators are decreased then they are unbonded (along with text explaining the funds are going into the unbonding period).

(BTW I started working on this in #257)

@nylira
Copy link
Contributor

nylira commented Dec 19, 2017

Matt has the right process. PageBond is where can you bond and unbond. Setting a delegate's atoms to zero currently results in a UI error*, but you can click the delete button to unbond from them.

* it's debatable whether it should be an error, but I'm thinking that the user may have made an error in their bond settings if they attempt to submit the form with a delegate in their cart set to 0 atoms

@jbibla
Copy link
Collaborator

jbibla commented Dec 19, 2017

this sounds good to me. my only objection is to the checkmark in the top bar. i'd much prefer if this was a primary button above the table. even this could use some work — i think people will be afraid to click the button if they don't know what will happen next. i would be. "MAYBE ALL MY ATOMS WILL BE SENT TO THESE PEOPLE" they'll say... maybe the button could say "Next". not sure about this.

the screen has two purposes which can be confusing. it's about consuming information about validators / candidates AND bonding / delegating. we separate this out for balances and send... we might consider a separation for delegation as well.

@nylira
Copy link
Contributor

nylira commented Dec 19, 2017

The checkmark is a placeholder. I think it needs a label and perhaps an accent color to show its importance -- I think it's in a good location though, because it'll scroll with the screen. Helpful in the case we have 100+ delegates.

We do have two pages for viewing validators and delegates. Validators is at the bottom of the menu. They should be streamlined to have the visual look though.

@faboweb faboweb closed this as completed Jan 2, 2018
@jbibla jbibla added this to the Launch v1 milestone Jan 22, 2018
faboweb added a commit that referenced this issue Jun 2, 2020
* fixed a bug where a single proposal would not load (#125)

* trigger ci

* fixed missing terra data source (#128)

* Fabo/fix missing terra db query (#130)

* fixed missing terra data source

* fixed missing query

* Fabo/fix failing staking query for terra (#132)

* fixed missing terra data source

* fixed missing query

* fix bech32 prefix in selfStake resolver

* linted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-work-needed 🎨 issues that require design work before development
Projects
None yet
Development

No branches or pull requests

5 participants