Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

form validation is INTENSE #151

Closed
jbibla opened this issue Dec 1, 2017 · 1 comment
Closed

form validation is INTENSE #151

jbibla opened this issue Dec 1, 2017 · 1 comment
Assignees
@faboweb

Comments

@jbibla
Copy link
Collaborator

jbibla commented Dec 1, 2017 •
edited
Loading

i'm curious to hear everyone's thoughts on this. basically, the validation on our form fields kicks in right away. so if you try to send someone some tokens and you type 1 character the form turns red and you get an error. it can feel quite aggressive. as an alternative, i'll propose a couple options.

  1. validate form on submit
  2. add a sensible delay on keyup to the validation

what do you guys think about this?
@jbibla jbibla added the question label Dec 1, 2017
@nylira
Copy link
Contributor

nylira commented Dec 4, 2017

This is a bug with our code. Validation shouldn't be kicking in until submit is hit for the first time.

@nylira nylira mentioned this issue Dec 4, 2017
Merged
@faboweb faboweb unassigned nylira and mappum Apr 1, 2019
faboweb added a commit that referenced this issue Jun 2, 2020
@faboweb
Fabo/fix unsafe eval (#151)
a813f19 
* somehow webpack uses unsafe eval in development mode

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faboweb faboweb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nylira @mappum @faboweb @jbibla