Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve explorer mode #2170

Closed
faboweb opened this issue Mar 5, 2019 · 2 comments · Fixed by #2176
Closed

Improve explorer mode #2170

faboweb opened this issue Mar 5, 2019 · 2 comments · Fixed by #2176
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@faboweb
Copy link
Collaborator

faboweb commented Mar 5, 2019

Describe the bug

the wallet page is still blank and the tx page shows no transactions instead of the sign in card if the user not signed in
Do we even need to prompt right away for sign in?

To Reproduce

Sign in
Go to Wallet

Expected behavior

Show sign in card

Screenshots

Desktop (please complete the following information):

  • OS:
  • Browser:
  • Version:

Smartphone (please complete the following information):

  • Device:
  • OS:
  • Browser
  • Version

Additional context
@faboweb faboweb added the bug 🐛 issues related to unhandled errors in the code that need to be fixed label Mar 5, 2019
@jbibla
Copy link
Collaborator

jbibla commented Mar 5, 2019

wasn't your sign in card PR supposed to resolve this?

@faboweb
Copy link
Collaborator Author

faboweb commented Mar 5, 2019

I just added it as a fallback. Plus it apparently is missing on 2 pages. Might be my fault.

@jbibla jbibla mentioned this issue Mar 5, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jordan/2170 explorer mode fixes luniehq/lunie
2 participants
@faboweb @jbibla