Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jordan/2170 explorer mode fixes #2176

Merged
merged 12 commits into from
Mar 7, 2019
Merged

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Mar 5, 2019

Closes #2170

Description:

  • fixed bug in card signed in
  • updated sentence on no-proposal message
  • hide faucet while not signed in

Thank you! 🚀


For contributor:

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #2176 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2176      +/-   ##
===========================================
- Coverage    95.43%   95.42%   -0.01%     
===========================================
  Files          109      109              
  Lines         2299     2295       -4     
  Branches       109      110       +1     
===========================================
- Hits          2194     2190       -4     
  Misses          92       92              
  Partials        13       13
Impacted Files Coverage Δ
app/src/renderer/components/common/TmPage.vue 100% <ø> (ø) ⬆️
app/src/renderer/scripts/boot.js 97.14% <ø> (-0.3%) ⬇️
...rc/renderer/components/governance/TabProposals.vue 100% <ø> (ø) ⬆️
.../renderer/components/common/CardSignInRequired.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/wallet/PageWallet.vue 96.29% <100%> (ø) ⬆️

fedekunze
fedekunze previously approved these changes Mar 5, 2019
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK

Co-Authored-By: jbibla <jbibla@gmail.com>
faboweb
faboweb previously approved these changes Mar 6, 2019
faboweb
faboweb previously approved these changes Mar 7, 2019
color="green"
value="Get Tokens"
/>
<!---->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting this to be shown, faucet is set and signedIn is true

Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mrrrrrggggg

@sabau sabau merged commit a392492 into develop Mar 7, 2019
@sabau sabau deleted the jordan/2170-explorer-mode-fixes branch March 7, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve explorer mode
4 participants