Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect logic not being triggered #307

Closed
mappum opened this issue Jan 2, 2018 · 1 comment
Closed

Reconnect logic not being triggered #307

mappum opened this issue Jan 2, 2018 · 1 comment
Assignees
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@mappum
Copy link
Contributor

mappum commented Jan 2, 2018

Meant to leave this as a review on #283, but wasn't quite fast enough 😛

For this code:
https://github.com/cosmos/cosmos-ui/pull/283/files#diff-d2589d9a81753ea8fa56e1202bff83f6R41

I tried to reproduce a node disconnect by turning off my wifi and reloading my wallet balance. But it looks like this error handler never gets called in that case since the refresh makes its request to the relayServer which is still alive. So I think the reconnect logic won't ever get triggered, @faboweb were you able to trigger it outside of the tests?

The RPC client gets a response of 500 Internal Server Error with the error in the body: Error: connect ECONNREFUSED 127.0.0.1:8998. We'll need a way of having the app detect when it gets a 500 response (assuming the LCD only gives 500s when it can't connect to the node), then it could do the same as what's in this error handler.

@jbibla jbibla added the bug 🐛 issues related to unhandled errors in the code that need to be fixed label Jan 2, 2018
@faboweb
Copy link
Collaborator

faboweb commented Jan 3, 2018

I triggered the status by connecting to a local node and turning that one on and off. I will follow up on this.

@faboweb faboweb self-assigned this Jan 3, 2018
@faboweb faboweb closed this as completed Jan 4, 2018
faboweb added a commit that referenced this issue Jun 2, 2020
* Fabo/fix gas (#250)

* fix gas estimate

* linted

* fixed test

* do not keep data sources (#251)

* track failing transactions in Sentry (#249)

* correctly set the tx schema for a failing tx (#248)

* Fabo/remove per block caching as not working (#247)

* remove per block caching as not working

* fix memoized results

Co-authored-by: Ana G. <40721795+Bitcoinera@users.noreply.github.com>

* delete perblockcachedatasource (#253)

* Ana/fix balances in actionmodal (#255)

* fix action modal available balance

* include regen

* use dictionary for denomlookup

* use correct events for received txs (#257)

* enable account creation for some networks (#252)

* network update time metric added (#256)

* network update time metric added

* added missing dep

Co-authored-by: Fabian <frznhope@gmail.com>

* Fix proposal deposit (#261)

* Remove denom handling from getDeposit()

* Revert undesired change

* delete package-lock.json

* localtestnet config change (#265)

* Ana/handle "address not from this network" error (#263)

* add check address function for all queries

* apply suggestions

* Ana/add fiatvalue to balances query (e-Money) (#262)

* preparation

* more preparation

* add fiatvalue field to balances query

* fix get account info

* apply suggestions

* apply one last suggestion

* suggestions+

Co-authored-by: Fabian <frznhope@gmail.com>

* Ana/emoney fix expected returns with inflation and totalbacked (#243)

* fix expected returns with inflation and supply

* minor fixes. dictionary

* query exchange rates from emoney api

* fix infinite expected returns

* convert api url to const

* add eur value to totalbackedvalue. totalngm gains

* add important comment

* finish calculation

* lint

* catch errors with sentry

Co-authored-by: Fabian <frznhope@gmail.com>

* readd coin conversion (#268)

* delete amount field (#274)

* Fabo/increase gas again (#271)

* icrease gas again

* fixed test

* Fabo/load all txs (even if more then first page in response) (#270)

* load all txs (even if more then first page in response)

* improved handling of txs

* missing renaming

* fixed paginated load

* add pagination fix also to cosmosV0-source

Co-authored-by: iambeone <iambeone@gmail.com>
Co-authored-by: Ana G. <40721795+Bitcoinera@users.noreply.github.com>

* fixing issue with multiple senders in one event (#273)

* fixing issue with multiple senders in one event

* Update lib/source/cosmosV2-source.js

Co-authored-by: Fabian <frznhope@gmail.com>

* Fabo/allow signing for terra + emoney (#267)

* allow signing for terra

* readd coin conversion

* enable actions for terra

* fix correct terra testnet url

* comments and guards

* enabled more txs for emoney and fixed broadcasting

* added a catch for wrongly formatted broadcast urls

* recover default field. change some network titles (#277)

* Fabo/add network data to API (#278)

* non desctructive introduction of better address prefix wording

* added address creator to API

* adjusted test

* added ledger app to networks config

* add icon property to schema (#281)

* add icon property to schema

* fix network schema validation

Co-authored-by: Ana G. <40721795+Bitcoinera@users.noreply.github.com>

* filter out validator specific txs (#279)

* Ana/balances coinreducer good fix (#269)

* balances coinreducer good fix

* refactored fiat value logic

Co-authored-by: Fabian <frznhope@gmail.com>

* Create network_integration.md

* Update network_integration.md

* Update network_integration.md

* Fabo/avoid 500 errors (#288)

* avoid using the latest query

* cleanup

* Ana/filter validator tx cross network and add txvalue reducer (#285)

* filter validators cross network

* add value reducer. necessary for multi claim txs

* add validator txs filter also for cosmosv0 source

* filter and make array only claim rewards msg value

* filter txs by whitelist

* change length in multi claim reward reducer

* add withdrawvalidators

* replace dictionary for set

* refactor transaction snippet. avoid repetition

* Ana/emoney upgrade (mergeable) (#282)

* update emoney api_url

* fix denom. add default fiat currency

* fix rpc endpoint

* fix value (my bad) (#293)

* fix value (my bad)

* trigger another ci flow

* erase space

* set correct new chain id (#294)

* restart API

* restart API

* fix pr alert (#297)

* Fabo/298 tendermint reconnect (#300)

* reconnect on tendermint disconnect

* cleanup

* comments

* Update cosmos-node-subscription.js

* Fabo/299 trigger a chain hangup error (#301)

* trigger a chain hangup error

* increase chain hangup time

* Apply suggestions from code review

* Fabo/store validator addresses (#296)

* add validator addresses to db

* linted

* ignore in local dev

* revert

* fixed fetch

* comment

* refactored db into constructor

* cleanup

* add clearTimeout to avoid reconnection hell (#306)

* add clearTimeout to avoid reconnection hell

* removed console.log

Co-authored-by: Ana G. <40721795+Bitcoinera@users.noreply.github.com>
Co-authored-by: Aleksey Rudometov <iambeone@gmail.com>
Co-authored-by: Mario Pino <info@quequiereshacer.es>
Co-authored-by: Jordan Bibla <jbibla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Development

No branches or pull requests

3 participants