Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximize Window on Start #170

Closed
wants to merge 4 commits into from
Closed

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Dec 5, 2017

Relates to #138
Pulled out from #147

@faboweb
Copy link
Collaborator Author

faboweb commented Dec 5, 2017

I am opposed to this. This feels unnatural for me. Apps I know don't maximize on start.

@nylira
Copy link
Contributor

nylira commented Dec 5, 2017

During development I have the dev tools open nearly all the time -- so I like having the window maximized. However, I agree that it shouldn't be a production default. Is there a way to specify develop only?

@jbibla jbibla closed this Dec 5, 2017
@jbibla jbibla deleted the jordan/138-electron-stuff branch December 5, 2017 19:03
@faboweb
Copy link
Collaborator Author

faboweb commented Dec 6, 2017

@jolesbi did you close this by accident? I added fe62a12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants