Make sends more reliable #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nylira
previously approved these changes
Dec 8, 2017
nylira
approved these changes
Dec 8, 2017
|
@mappum what happened to adding tests here? Too difficult to test ? If so that's something we should probably work on since this is relatively critical functionality |
|
Will add tests before releasing
…On Fri, Dec 8, 2017 at 7:09 PM, Ethan Buchman ***@***.***> wrote:
@mappum <https://github.com/mappum> what happened to adding tests here?
Too difficult to test ? If so that's something we should probably work on
since this is relatively critical functionality
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#206 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAYTzSQb2Z0xYzDvwv_vsr34A3ZEmqmGks5s-YlRgaJpZM4Q6mum>
.
|
faboweb
pushed a commit
that referenced
this pull request
Jun 2, 2020
* update submodule to existing one * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ebuchman was testing out the send functionality by spamming sends, and found that the account nonce was not being properly incremented with each successive transaction, so only the first one was actually going through (even though the UI showed success). This PR ensures we see error results on tx send, ensures the account nonce properly increases as we send, and puts sends in a queue to ensure only one happens at a time.