Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/fix page proposal showing header #2192

Merged
merged 10 commits into from
Mar 7, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 6, 2019

Before:
image

After:
image

Description:

Thank you! 🚀


For contributor:

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #2192 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2192      +/-   ##
===========================================
- Coverage    95.42%   95.41%   -0.01%     
===========================================
  Files          109      109              
  Lines         2295     2291       -4     
  Branches       110      110              
===========================================
- Hits          2190     2186       -4     
  Misses          92       92              
  Partials        13       13
Impacted Files Coverage Δ
...src/renderer/components/common/PagePreferences.vue 100% <ø> (ø) ⬆️
...rc/renderer/components/governance/PageProposal.vue 97.67% <ø> (-0.11%) ⬇️

@faboweb faboweb merged commit 0f4d1b3 into develop Mar 7, 2019
@faboweb faboweb deleted the fabo/fix-page-proposal-showing-header branch March 7, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants