Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/2193 hide import #2194

Merged
merged 7 commits into from
Mar 6, 2019
Merged

Fabo/2193 hide import #2194

merged 7 commits into from
Mar 6, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 6, 2019

Closes #2193

Description:

Thank you! 🚀


For contributor:

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #2194 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2194   +/-   ##
========================================
  Coverage    95.46%   95.46%           
========================================
  Files          108      108           
  Lines         2293     2293           
  Branches       112      112           
========================================
  Hits          2189     2189           
  Misses          94       94           
  Partials        10       10
Impacted Files Coverage Δ
...rc/renderer/components/common/TmSessionWelcome.vue 100% <ø> (ø) ⬆️

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #2194 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2194   +/-   ##
========================================
  Coverage    95.46%   95.46%           
========================================
  Files          108      108           
  Lines         2293     2293           
  Branches       112      112           
========================================
  Hits          2189     2189           
  Misses          94       94           
  Partials        10       10
Impacted Files Coverage Δ
...rc/renderer/components/common/TmSessionWelcome.vue 100% <ø> (ø) ⬆️

jbibla
jbibla previously approved these changes Mar 6, 2019
@fedekunze fedekunze requested a review from jbibla March 6, 2019 17:29
@jbibla jbibla merged commit 6ff1656 into develop Mar 6, 2019
jbibla pushed a commit that referenced this pull request Mar 7, 2019
* remove modals

* tests

* cha cha cha

* refactored delegation modal tests

* removed the "to" field on undelegation action modals

* updated undelegation modal msg

* lint

* Fabo/gov fixes (#2167)

* defensive programming

* fixed

* fixed sorting

* optimistic updates

* modals clear forms correctly

* fedes changes

* fixed tests

* fixed more tests

* changelog

* coverage

* Update CHANGELOG.md

Co-Authored-By: faboweb <frznhope@gmail.com>

* added coverage

* added optimistic updates for proposal creation

* Jordan/2161 fixed positioning of status dot (#2172)

* fixed positioning of status dot

* fix for validator profile status

* removed arrows from buttons, updated snaperoos

* reduce margin on page validator avatar

* Update CHANGELOG.md

Co-Authored-By: jbibla <jbibla@gmail.com>

* added cosmoswallet config file

* Update CHANGELOG.md

* Fabo/2195 fix wrong amount on undelegation modal (#2196)

* defensive programming

* done

* fixed tests

* removed old fix

* Fabo/2193 hide import (#2194)

* defensive programming

* hide import

* changelog

* tests

* Fabo/1884 bring back e2e tests (#2140)

* added nightwatch

* changelog

* direct to the correct endpoints

* fixed setup and import key

* reenable e2e

* fixed yaml

* switch workspace path

* change workspace

* playing with paths

* paths

* paths

* paths

* paths

* cache bust

* fix build script

* fix build

* only copy if build

* try fixing glob test

* attach correct workspace

* correct paths

* test without localstorage

* serve build files for e2e tests

* require build

* run http-server in parallel

* fix paths

* updated readme

* cleanup

* cleanup

* linted

* Bump version for release.
@colw colw deleted the fabo/2193-hide-import branch June 20, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DevFlag seeds import
3 participants