Add eslint basic rules

.eslintrc.js

@@ -57,6 +57,10 @@ module.exports = {
     "array-bracket-spacing": ["error", "never"],
     "indent": ["error", 2, { "SwitchCase": 1 }],
     "no-console": "off",
-    "semi": ["error", "never"]
+    "brace-style": ["error", "1tbs"],
+    "semi": ["error", "never"],
+    "no-tabs": ["error"],
+    "max-len": ["error", { "code": 80, "ignoreStrings": true, "ignoreComments": true, "ignoreTemplateLiterals": true }],
+    "no-trailing-spaces": ["error", { "skipBlankLines": false }]
   }
 }

PENDING.md

@@ -9,6 +9,8 @@
 ### Changed
 
 - [#\2202](https://github.com/cosmos/voyager/pull/2202) Fix circle configuration for publishing @sabau
+- [#\2236](https://github.com/cosmos/voyager/pull/2236) ES lint no tabs @sabau
+- [\#1805](https://github.com/cosmos/voyager/issues/1805) support all transaction types @fedekunze
 - [#\2211](https://github.com/cosmos/voyager/pull/2211) simplified sidebar and mobile menu, cleaned up css, fixed tests @jbibla
 
 ### Fixed

app/src/renderer/components/common/FundraiserWarning.vue

@@ -1,6 +1,7 @@
 <template>
   <p class="fundraiser-warning">
-    Warning – Do not enter your actual 12 or 24 word fundraiser seed. This feature is only for testing Voyager and is considered highly insecure.
+    Warning – Do not enter your actual 12 or 24 word fundraiser seed.
+    This feature is only for testing Voyager and is considered highly insecure.
   </p>
 </template>
 

app/src/renderer/components/common/TextBlock.vue

@@ -1,5 +1,6 @@
 <template>
-  <!-- TODO:SECURITY try to add a malicious block and see how is rendered, like <script>alert('danger')</script> -->
+  <!-- TODO:SECURITY try to add a malicious block and see how is rendered,
+  like <script>alert('danger')</script> -->
   <!-- eslint-disable vue/no-v-html -->
   <div class="text-block" v-html="htmlContent" />
 </template>

app/src/renderer/components/common/TmConnectedNetwork.vue

@@ -33,7 +33,10 @@
     <img class="tm-connected-network-loader" src="~assets/images/loader.svg" />
     <div
       v-tooltip.top="networkTooltip"
-      class="tm-connected-network__string tm-connected-network__string--connecting"
+      class="
+        tm-connected-network__string
+        tm-connected-network__string--connecting
+      "
     >
       Connecting to {{ lastHeader.chain_id }}…
     </div>

app/src/renderer/components/common/TmField.vue

@@ -46,7 +46,8 @@
     <div class="tm-toggle-wrapper" @click.prevent="toggle">
       <span>
         {{
-          currentToggleState ? resolvedOptions.checked : resolvedOptions.unchecked
+          currentToggleState ?
+            resolvedOptions.checked : resolvedOptions.unchecked
         }}
       </span>
       <div class="toggle-option-checked">

app/src/renderer/components/common/TmFormGroup.vue

@@ -1,6 +1,9 @@
 <template>
   <div :class="cssClass">
-    <span v-if="subLabel" class="tm-form-group__sub-label">{{ subLabel }}</span><label
+    <span v-if="subLabel" class="tm-form-group__sub-label">
+      {{ subLabel }}
+    </span>
+    <label
       v-if="fieldId && fieldLabel"
       :for="fieldId"
       class="tm-form-group__label"

app/src/renderer/components/common/TmListItem.vue

@@ -22,7 +22,8 @@
         <div v-else class="tm-li-dd">{{ dd }}</div>
       </div>
       <div class="tm-li-icon">
-        <i class="material-icons inactive">chevron_right</i><i class="material-icons active">my_location</i>
+        <i class="material-icons inactive">chevron_right</i>
+        <i class="material-icons active">my_location</i>
       </div>
     </div>
   </a>
@@ -81,7 +82,8 @@
         </div>
       </div>
       <div class="tm-li-icon">
-        <i class="material-icons inactive">chevron_right</i><i class="material-icons active">my_location</i>
+        <i class="material-icons inactive">chevron_right</i>
+        <i class="material-icons active">my_location</i>
       </div>
     </div>
   </router-link>
@@ -167,7 +169,8 @@
         <div class="tm-li-subtitle">{{ subtitle }}</div>
       </div>
       <div class="tm-li-icon">
-        <i class="material-icons inactive">chevron_right</i><i class="material-icons active">my_location</i>
+        <i class="material-icons inactive">chevron_right</i>
+        <i class="material-icons active">my_location</i>
       </div>
     </div>
   </a>
@@ -195,7 +198,8 @@
         </div>
       </div>
       <div class="tm-li-icon">
-        <i class="material-icons inactive">chevron_right</i><i class="material-icons active">my_location</i>
+        <i class="material-icons inactive">chevron_right</i>
+        <i class="material-icons active">my_location</i>
       </div>
     </div>
   </router-link>

app/src/renderer/components/common/TmSession.vue

@@ -7,7 +7,9 @@
       <session-account-delete
         v-else-if="session.modals.session.state == 'delete'"
       />
-      <session-hardware v-else-if="session.modals.session.state == 'hardware'" />
+      <session-hardware
+        v-else-if="session.modals.session.state == 'hardware'"
+      />
       <session-import v-else-if="session.modals.session.state == 'import'" />
     </div>
     <connected-network />
@@ -37,7 +39,7 @@ export default {
     SessionAccountDelete,
     ConnectedNetwork
   },
-  computed: { 
+  computed: {
     ...mapGetters([`session`]),
     active() {
       return this.session.modals.session.active

app/src/renderer/components/common/TmSessionAccountDelete.vue

@@ -90,9 +90,9 @@ export default {
     TmFormMsg,
     TmFormStruct
   },
-  data: () => ({ 
+  data: () => ({
     deletionPassword: ``,
-    deletionWarning: false 
+    deletionWarning: false
   }),
   mounted() {
     this.$el.querySelector(`#sign-in-password`).focus()

app/src/renderer/components/common/TmSessionSignUp.vue

@@ -100,8 +100,8 @@
           <tm-form-msg
             class="sm"
             type="custom"
-            msg="Please back up the seed phrase for this account. This seed phrase
-            cannot be recovered."
+            msg="Please back up the seed phrase for this account.
+            This seed phrase cannot be recovered."
           />
         </tm-form-group>
         <tm-form-group

app/src/renderer/components/common/ToolBar.vue

@@ -12,7 +12,11 @@
     <router-link v-if="session.signedIn" id="settings" to="/preferences">
       <i v-tooltip.bottom="'Preferences'" class="material-icons">settings</i>
     </router-link>
-    <a v-if="session.signedIn" id="signOut-btn" @click="signOut()">
+    <a
+      v-if="session.signedIn"
+      id="signOut-btn"
+      @click="signOut()"
+    >
       <i
         v-tooltip.bottom.end="'Sign Out'"
         class="material-icons"

app/src/renderer/components/governance/PageProposal.vue

@@ -104,7 +104,9 @@
           <dl class="info_dl colored_dl">
             <dt>No with Veto</dt>
             <dd>
-              {{ num.atoms(tally.no_with_veto) }} / {{ noWithVetoPercentage }}
+              {{
+                num.atoms(tally.no_with_veto) }} / {{ noWithVetoPercentage
+              }}
             </dd>
           </dl>
           <dl class="info_dl colored_dl">

app/src/renderer/components/governance/TabProposals.vue

@@ -4,7 +4,8 @@
   <tm-data-empty
     v-else-if="Object.keys(proposals.proposals).length === 0"
     title="No Governance Proposals"
-    subtitle="There are currently no governance proposals to display. Click the 'Create Proposal' button to submit a proposal."
+    subtitle="There are currently no governance proposals to display.
+    Click the 'Create Proposal' button to submit a proposal."
   />
   <table-proposals
     v-else

app/src/renderer/components/network/PageBlock.vue

@@ -34,7 +34,9 @@
             <dl class="info_dl colored_dl">
               <dt>Transactions</dt>
               <dd>
-                {{ (block.block && block.block.data.txs) || `No Transactions` }}
+                {{
+                  block.block && block.block.data.txs || `No Transactions`
+                }}
               </dd>
             </dl>
           </div>
@@ -48,8 +50,7 @@
               <dt>Evidence</dt>
               <dd>
                 {{
-                  (block.block && block.block.evidence.evidence) ||
-                    `No Evidence`
+                  block.block && block.block.evidence.evidence || `No Evidence`
                 }}
               </dd>
             </dl>

app/src/renderer/components/staking/LiValidator.vue

@@ -10,7 +10,10 @@
       >
       <img
         v-else
-        class="data-table__row__info__image data-table__row__info__image--no-img"
+        class="
+          data-table__row__info__image
+          data-table__row__info__image--no-img
+        "
         src="~assets/images/validator-icon.svg"
         width="48"
         height="48"

app/src/renderer/components/transactions/LiBankTransaction.vue

@@ -6,7 +6,9 @@
   >
     <template v-if="sent">
       <div slot="caption">
-        Sent&nbsp;<b>{{ full(atoms(coins.amount)) }}</b><span>&nbsp;{{ coins.denom.toUpperCase() }}</span>
+        Sent&nbsp;
+        <b>{{ full(atoms(coins.amount)) }}</b>
+        <span>&nbsp;{{ coins.denom.toUpperCase() }}</span>
       </div>
       <span slot="details">
         <template v-if="sentSelf">
@@ -17,7 +19,10 @@
       </span>
     </template><template v-else>
       <div slot="caption">
-        Received&nbsp;<b>{{ full(atoms(coins.amount)) }}</b><span>&nbsp;{{ coins.denom.toUpperCase() }}</span>
+
+        Received&nbsp;
+        <b>{{ full(atoms(coins.amount)) }}</b>
+        <span>&nbsp;{{ coins.denom.toUpperCase() }}</span>
       </div>
       <span slot="details">From {{ sender }}</span>
     </template>

app/src/renderer/components/transactions/LiDistributionTransaction.vue

@@ -24,7 +24,9 @@
         To {{ tx.withdraw_address }}
       </div>
     </template>
-    <template v-else-if="txType === `cosmos-sdk/MsgWithdrawValidatorCommission`">
+    <template
+      v-else-if="txType === `cosmos-sdk/MsgWithdrawValidatorCommission`"
+    >
       <div slot="caption">
         Withdraw validator commission
       </div>

app/src/renderer/components/transactions/LiGovTransaction.vue

@@ -6,7 +6,9 @@
   >
     <template v-if="txType === `cosmos-sdk/MsgSubmitProposal`">
       <div slot="caption">
-        Submit {{ tx.proposal_type.toLowerCase() }} proposal&nbsp;<b>{{ full(atoms(tx.initial_deposit[0].amount)) }}</b><span>&nbsp;{{ tx.initial_deposit[0].denom }}s</span>
+        Submit {{ tx.proposal_type.toLowerCase() }} proposal&nbsp;
+        <b>{{ full(atoms(tx.initial_deposit[0].amount)) }}</b>
+        <span>&nbsp;{{ tx.initial_deposit[0].denom }}s</span>
       </div>
       <div slot="details">
         Title:&nbsp;<i>{{ tx.title }}</i>

app/src/renderer/vuex/modules/connection.js

@@ -98,7 +98,7 @@ export default function({ node }) {
         },
         ({ header }) => {
           dispatch(`setLastHeader`, header)
-          
+
           if (rootState.session.signedIn) {
             dispatch(`getTotalRewards`)
           }

app/src/renderer/vuex/modules/distribution.js

@@ -8,35 +8,35 @@ export default ({ node }) => {
     loaded: false,
     error: null,
     /* totalRewards use the following format:
-        { 
+        {
             denom1: amount1,
             ... ,
-            denomN: amountN 
+            denomN: amountN
         }
     */
     totalRewards: {},
     /* rewards use the following format:
-        { 
-            validatorAddr1: { 
+        {
+            validatorAddr1: {
                 denom1: amount1,
                 ... ,
-                denomN: amountN 
+                denomN: amountN
             },
             ... ,
-            validatorAddrN: { 
+            validatorAddrN: {
                 denom1: amount1,
                 ... ,
-                denomN: amountN 
-            } 
-        } 
+                denomN: amountN
+            }
+        }
     */
     rewards: {},
     parameters: {},
     /* outstandingRewards use the following format:
-        { 
+        {
             denom1: amount1,
             ... ,
-            denomN: amountN 
+            denomN: amountN
         }
     */
     outstandingRewards: {}
@@ -106,10 +106,16 @@ export default ({ node }) => {
       state.loading = false
       state.loaded = true
     },
-    async getRewardsFromValidator({ state, rootState: { session }, commit }, validatorAddr) {
+    async getRewardsFromValidator(
+      { state, rootState: { session }, commit },
+      validatorAddr
+    ) {
       state.loading = true
       try {
-        const rewardsArray = await node.getDelegatorRewardsFromValidator(session.address, validatorAddr)
+        const rewardsArray = await node.getDelegatorRewardsFromValidator(
+          session.address,
+          validatorAddr
+        )
         const rewards = coinsToObject(rewardsArray)
         commit(`setDelegationRewards`, { validatorAddr, rewards })
         commit(`setDistributionError`, null)
@@ -137,7 +143,8 @@ export default ({ node }) => {
     async getOutstandingRewards({ commit }) {
       state.loading = true
       try {
-        const oustandingRewardsArray = await node.getDistributionOutstandingRewards()
+        const oustandingRewardsArray =
+          await node.getDistributionOutstandingRewards()
         const oustandingRewards = coinsToObject(oustandingRewardsArray)
         commit(`setOutstandingRewards`, oustandingRewards)
         commit(`setDistributionError`, null)

app/src/renderer/vuex/modules/governance/deposits.js

@@ -48,10 +48,11 @@ export default ({ node }) => {
         password,
         submitType
       })
-      
+
       // optimistic update
       deposit.forEach(({ amount, denom }) => {
-        const oldBalance = wallet.balances.find(balance => balance.denom === denom)
+        const oldBalance = wallet.balances
+          .find(balance => balance.denom === denom)
         commit(`updateWalletBalance`, {
           denom,
           amount: oldBalance.amount - amount

app/src/renderer/vuex/modules/governance/proposals.js

@@ -93,10 +93,11 @@ export default ({ node }) => {
         password,
         submitType
       })
-      
+
       // optimistic updates
       initial_deposit.forEach(({ amount, denom }) => {
-        const oldBalance = wallet.balances.find(balance => balance.denom === denom)
+        const oldBalance = wallet.balances
+          .find(balance => balance.denom === denom)
         commit(`updateWalletBalance`, {
           denom,
           amount: BigNumber(oldBalance.amount).minus(amount).toNumber()

app/src/renderer/vuex/modules/send.js

@@ -122,7 +122,7 @@ export default ({ node }) => {
         const signatureBuffer = state.externals.signatureImport(
           signatureByteArray
         )
-        /* 
+        /*
           NOTE: message is not hashed since Ledger needs to display it on screen
           and then internally hashes the json before signing it
         */

app/src/renderer/vuex/modules/session.js

@@ -144,7 +144,8 @@ export default () => {
         default:
           // local keyStore
           state.localKeyPairName = localKeyPairName
-          accountAddress = (await state.externals.loadKeys()).find(({ name }) => name === localKeyPairName).address
+          accountAddress = (await state.externals.loadKeys())
+            .find(({ name }) => name === localKeyPairName).address
       }
       commit(`setSignIn`, true)
       dispatch(`setErrorCollection`, {