-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fabo/ ignore changelog check on master #2248
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2248 +/- ##
=======================================
Coverage 96.3% 96.3%
=======================================
Files 109 109
Lines 2300 2300
Branches 116 116
=======================================
Hits 2215 2215
Misses 72 72
Partials 13 13 |
Codecov Report
@@ Coverage Diff @@
## develop #2248 +/- ##
========================================
Coverage 96.62% 96.62%
========================================
Files 108 108
Lines 2314 2314
Branches 116 116
========================================
Hits 2236 2236
Misses 65 65
Partials 13 13 |
instead of ignoring pending on master, shouldn’t we actually check the changelog? |
I think that would be over engineering. If this would be a problem I volunteer to implement that check in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One step more to not fail the nightly
Closes #ISSUE
Description:
Thank you! 🚀
For contributor:
PENDING.md
with issue # and GitHub usernameFiles changed
in the github PR explorerFor reviewer: