Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/ ignore changelog check on master #2248

Merged
merged 4 commits into from
Mar 13, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 13, 2019

Closes #ISSUE

Description:

Thank you! 🚀


For contributor:

  • Added entries in PENDING.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

fedekunze
fedekunze previously approved these changes Mar 13, 2019
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #2248 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #2248   +/-   ##
=======================================
  Coverage     96.3%   96.3%           
=======================================
  Files          109     109           
  Lines         2300    2300           
  Branches       116     116           
=======================================
  Hits          2215    2215           
  Misses          72      72           
  Partials        13      13

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #2248 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2248   +/-   ##
========================================
  Coverage    96.62%   96.62%           
========================================
  Files          108      108           
  Lines         2314     2314           
  Branches       116      116           
========================================
  Hits          2236     2236           
  Misses          65       65           
  Partials        13       13

@jbibla
Copy link
Collaborator

jbibla commented Mar 13, 2019

instead of ignoring pending on master, shouldn’t we actually check the changelog?

@faboweb
Copy link
Collaborator Author

faboweb commented Mar 13, 2019

I think that would be over engineering. If this would be a problem I volunteer to implement that check in the future.

Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One step more to not fail the nightly

@jbibla jbibla merged commit b46247f into develop Mar 13, 2019
@jbibla jbibla deleted the fabo/ignore-changelog-check-on-master branch March 13, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants