Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic release created for v1.0.0-beta.19 #2276

Merged
merged 20 commits into from
Mar 15, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 15, 2019

Added

  • #2263 Added guide on how to connect via a local full node to any network @faboweb

Fixed

  • Fix for inflation on our testnet
  • #2257 fixed console error on page validator if loading the page from URL @faboweb

Changed

Voyager Bot and others added 19 commits March 13, 2019 15:35
Co-Authored-By: faboweb <frznhope@gmail.com>
Co-Authored-By: faboweb <frznhope@gmail.com>
Co-Authored-By: faboweb <frznhope@gmail.com>
Co-Authored-By: faboweb <frznhope@gmail.com>
* refactor tests, remove onboarding, fix error collection

* fixed tabs settings

* coverage

* pending

* Update PagePreferences.vue

* test timer

* altered tests

* removed page preferences; closes #2259
* fixed

* fixed tests

* Update PENDING.md

thx

Co-Authored-By: faboweb <frznhope@gmail.com>
@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #2276 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2276      +/-   ##
==========================================
+ Coverage   96.68%   96.73%   +0.05%     
==========================================
  Files         108      106       -2     
  Lines        2321     2296      -25     
  Branches      115      116       +1     
==========================================
- Hits         2244     2221      -23     
+ Misses         65       63       -2     
  Partials       12       12
Impacted Files Coverage Δ
.../src/renderer/components/staking/PageValidator.vue 100% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/session.js 100% <ø> (ø) ⬆️
app/src/renderer/components/common/ToolBar.vue 100% <ø> (ø) ⬆️
app/src/renderer/vuex/getters.js 90.56% <ø> (-0.18%) ⬇️
app/src/renderer/vuex/modules/index.js 100% <ø> (ø) ⬆️
app/src/renderer/components/common/Page404.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/TmField.vue 100% <100%> (ø) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #2276 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2276      +/-   ##
==========================================
+ Coverage   96.68%   96.73%   +0.05%     
==========================================
  Files         108      106       -2     
  Lines        2321     2296      -25     
  Branches      115      116       +1     
==========================================
- Hits         2244     2221      -23     
+ Misses         65       63       -2     
  Partials       12       12
Impacted Files Coverage Δ
.../src/renderer/components/staking/PageValidator.vue 100% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/session.js 100% <ø> (ø) ⬆️
app/src/renderer/components/common/ToolBar.vue 100% <ø> (ø) ⬆️
app/src/renderer/vuex/getters.js 90.56% <ø> (-0.18%) ⬇️
app/src/renderer/vuex/modules/index.js 100% <ø> (ø) ⬆️
app/src/renderer/components/common/Page404.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/TmField.vue 100% <100%> (ø) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to include #2274

@faboweb faboweb merged commit 3e49d77 into master Mar 15, 2019
@fedekunze
Copy link
Contributor

why was this merged without #2274 ??

@faboweb
Copy link
Collaborator Author

faboweb commented Mar 15, 2019

because it's the nightly PR and I don't manually change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants