Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/ fixed rewards not showing #2339

Merged
merged 2 commits into from
Mar 24, 2019
Merged

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Mar 24, 2019

The rewards were always 0 as we were displaying user owned atoms instead of uatoms.

@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #2339 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2339      +/-   ##
===========================================
+ Coverage    97.07%   97.07%   +<.01%     
===========================================
  Files          105      105              
  Lines         2325     2327       +2     
  Branches       124      124              
===========================================
+ Hits          2257     2259       +2     
  Misses          57       57              
  Partials        11       11
Impacted Files Coverage Δ
app/src/renderer/components/common/TmBalance.vue 100% <ø> (ø) ⬆️
...c/renderer/components/staking/TabMyDelegations.vue 96.15% <ø> (ø) ⬆️
app/src/renderer/vuex/getters.js 91.07% <ø> (ø) ⬆️
...pp/src/renderer/components/network/PageNetwork.vue 100% <ø> (ø) ⬆️
...rer/components/transactions/LiStakeTransaction.vue 100% <ø> (ø) ⬆️
...rer/components/staking/ModalWithdrawAllRewards.vue 92.85% <ø> (ø) ⬆️
...rc/renderer/components/staking/TableValidators.vue 100% <ø> (ø) ⬆️
...ponents/transactions/LiDistributionTransaction.vue 85.71% <ø> (ø) ⬆️
.../src/renderer/components/staking/PageValidator.vue 100% <100%> (ø) ⬆️
...nderer/components/staking/TabStakingParameters.vue 100% <100%> (ø) ⬆️
... and 1 more

1 similar comment
@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #2339 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2339      +/-   ##
===========================================
+ Coverage    97.07%   97.07%   +<.01%     
===========================================
  Files          105      105              
  Lines         2325     2327       +2     
  Branches       124      124              
===========================================
+ Hits          2257     2259       +2     
  Misses          57       57              
  Partials        11       11
Impacted Files Coverage Δ
app/src/renderer/components/common/TmBalance.vue 100% <ø> (ø) ⬆️
...c/renderer/components/staking/TabMyDelegations.vue 96.15% <ø> (ø) ⬆️
app/src/renderer/vuex/getters.js 91.07% <ø> (ø) ⬆️
...pp/src/renderer/components/network/PageNetwork.vue 100% <ø> (ø) ⬆️
...rer/components/transactions/LiStakeTransaction.vue 100% <ø> (ø) ⬆️
...rer/components/staking/ModalWithdrawAllRewards.vue 92.85% <ø> (ø) ⬆️
...rc/renderer/components/staking/TableValidators.vue 100% <ø> (ø) ⬆️
...ponents/transactions/LiDistributionTransaction.vue 85.71% <ø> (ø) ⬆️
.../src/renderer/components/staking/PageValidator.vue 100% <100%> (ø) ⬆️
...nderer/components/staking/TabStakingParameters.vue 100% <100%> (ø) ⬆️
... and 1 more

@faboweb faboweb merged commit 4ec8191 into develop Mar 24, 2019
@faboweb faboweb deleted the fabo/fix-rewards-not-showing branch March 24, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants