Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ana/3133 loader on networks page missing #3159

Merged
merged 3 commits into from
Nov 18, 2019

Conversation

Bitcoinera
Copy link
Contributor

@Bitcoinera Bitcoinera commented Nov 17, 2019

Closes #3133

Description:

I added the simple loader (TmDataLoading.vue) to the Networks page

Thank you! 🚀


For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@Bitcoinera
Copy link
Contributor Author

Oops, it seems this messed up with the unit tests... Makes sense

@Bitcoinera Bitcoinera self-assigned this Nov 17, 2019
@codecov
Copy link

codecov bot commented Nov 17, 2019

Codecov Report

Merging #3159 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3159      +/-   ##
===========================================
+ Coverage    88.35%   88.35%   +<.01%     
===========================================
  Files          125      125              
  Lines         1777     1778       +1     
  Branches       254      265      +11     
===========================================
+ Hits          1570     1571       +1     
  Misses         202      202              
  Partials         5        5
Impacted Files Coverage Δ
src/components/network/PageNetworks.vue 100% <100%> (ø) ⬆️

@@ -1,6 +1,7 @@
<template>
<TmPage data-title="Network" class="page" hide-header>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will accept the PR but want to show you that TmPage already has logic for loading states. Check PageValidator

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I saw! Thank you for the hint 😉 !

@faboweb faboweb merged commit e8cd1b9 into develop Nov 18, 2019
@faboweb faboweb deleted the ana/3133-loader-networks-page-missing branch November 18, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loader on Networks Page missing
2 participants