Jordan/mo mobile #3167
Jordan/mo mobile #3167
Conversation
|
Remember to put individual things in individual PRs |
| "release": "git checkout develop & git pull & git push origin develop:release", | ||
| "release:android": "git checkout develop && node ./tasks/bump-android-version.js && git commit android/app/build.gradle -m 'updated android app version' && git push origin develop:release-android", | ||
| "release:ios": "git checkout develop && node ./tasks/bump-ios-version.js && git commit ios/App/App/Info.plist -m 'updated ios app version' && git push origin develop:release-ios", | ||
| "serve:ios": "npx cap open ios & npm run serve", | ||
| "serve": "kill-port 9080 && vue-cli-service serve --port 9080", |
There was a problem hiding this comment.
this is just in alphabetical order now
i removed serve:ios because it isn't necessary
serve works if the correct url is in the capacitor config (it wasn't - it got removed somehow)
There was a problem hiding this comment.
really not needed change which can cause conflicts. ;)
tests/unit/specs/components/ActionModal/components/__snapshots__/ActionModal.spec.js.snap
Outdated
Show resolved
Hide resolved
tests/unit/specs/components/ActionModal/components/__snapshots__/ActionModal.spec.js.snap
Outdated
Show resolved
Hide resolved
| @@ -43,7 +43,7 @@ describe(`TmBalance`, () => { | |||
| wrapper.setData({ overview: false }) | |||
There was a problem hiding this comment.
this test is wrong. when not signed in, this should show nothing?
There was a problem hiding this comment.
it will show Total ATOM but not Available ATOM
There was a problem hiding this comment.
show empty stakes when not signed in
this is wrong. when not signed in, this should not show anything. we never show this component when not signed in any ways.
What you want is to change the test so it does not display Available ATOM when there are no tokens. Please pay attention to the tests and not just fix them so they pass.
There was a problem hiding this comment.
this whole test doesn't make sense then. "show empty stakes when not signed in" means don't show anything. so we can just use the snapshot - yeah?
There was a problem hiding this comment.
What you want is to change the test so it does not display Available ATOM when there are no tokens.
package.json
Outdated
| @@ -30,6 +29,7 @@ | |||
| "@babel/polyfill": "^7.4.4", | |||
| "@dicebear/avatars": "3.1.4", | |||
| "@dicebear/avatars-jdenticon-sprites": "1.1.4", | |||
| "@lunie/cosmos-api": "npm:@lunie/cosmos-api@0.2.x", | |||
Closes #3144
Description:
Thank you! 🚀
For contributor:
yarn changelogfor a guided process.Files changedin the github PR explorerFor reviewer: