-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transaction styling #3181
Merged
Merged
Transaction styling #3181
Changes from 6 commits
Commits
Show all changes
83 commits
Select commit
Hold shift + click to select a range
87a1011
Transaction styling
mariopino 3cb404f
changelog
mariopino d5b3818
Remove unused test, update snaps
mariopino 6336a54
Change background tx color on hover
mariopino 8ba5e9d
Add transition and new activity icons
mariopino e885e45
Add new icons
mariopino a63d6f0
Fix test, update snaps
mariopino 8e0159c
Fix e2e
mariopino 86821ed
Fix e2e
mariopino 29137be
Update snap
mariopino 92edf82
More testing stuff
mariopino b64e666
More testing and snaps
mariopino 063e39d
More testing stuff
mariopino a9c4b57
Fix e2e
mariopino cc1c8bc
Fix e2e
mariopino 718eac9
Trigger CI
mariopino cd8cc54
Fix e2e
mariopino fe192a8
Fix e2e
mariopino a35ec83
Update icons
mariopino 5586b44
cleaning up spacing in txs, using prettyInt, dropdown animation,
jbibla 5827fb8
Complete multisend support, cleanup
mariopino b83cc6a
Prevent collapse tx details when click on address
mariopino 139d637
Fix unit test
mariopino 4b64b62
Simplify TransactionIcon, fix test and update snap
mariopino 5857387
more testing
mariopino ba3cef0
Cleanup
mariopino ff85c94
Update snap
mariopino 15a4264
Add transaction metadata icons
mariopino 758248e
Update snap
mariopino dd8dfd9
fix date constantly changing
9aaef37
More testing (not completed!)
mariopino e7621a7
Merge branch 'mario/3078-improve-transaction-styling' of https://gith…
mariopino 86677e6
Complete caption, simplify
mariopino ac74614
Fix tests, update snaps
mariopino 8ede20a
More testing stuff
mariopino 4a669ae
Remove liquidDate, not supported at this moment
mariopino 83154ad
Remove unused tx in test
mariopino 2b98843
Lint, cleanup
mariopino a926e68
Fix space
mariopino 6f6b136
Fix spaces
mariopino ba7fbf5
Fix spaces
mariopino 4209221
add toggle icon
800a8f8
Update snaps
mariopino 84fe561
Pass whole transaction to TransactionMetadata
mariopino 35cb5d6
Fix test, update snap
mariopino beca585
Add undelegationEndTime
mariopino cccb94f
fix undelegationEndTime
Bitcoinera 3af8978
Add validator image to delegate
mariopino 41fd4c6
Merge branch 'mario/3078-improve-transaction-styling' of https://gith…
mariopino 3c42552
Remove undelegationEndTime until merge Ana pr
mariopino 04b122f
Add validator image to all staking tx
mariopino c291b4a
Cleanup
mariopino 6682cc9
Fix e2e
mariopino 72d11c5
add some coverage
Bitcoinera c745d7f
merge from remote
Bitcoinera 200242f
fix lint error
Bitcoinera ddbf2a8
add again undelegationEndTime to tx request
Bitcoinera 9076520
delete validator commission message
Bitcoinera e21c8ba
Remove undelegationEndTime
mariopino d8b1cdb
Merge branch 'develop' into mario/3078-improve-transaction-styling
mariopino 9091342
Merge develop
mariopino 308f2f2
made tx icon smaller on mobile and removed unneeded variables import
jbibla 4726d1b
simplified toggle icon and added rotation transition
jbibla 9f70b39
cleaning up styles and strange spacing / nbsp's
jbibla 63f3f1e
added validator images for redelegations
jbibla 48bc682
removed more unneeded nbsp's
jbibla ce2c192
added redelegation validator names back
jbibla 47f21da
updated snaperoos
jbibla d334cc7
switched from withdraw to claimed - as is our new language
jbibla 13dcc89
added details as subtitle on web and mobile
jbibla 819403b
reduced css for tx component, fully responsive too
jbibla 8462ade
tests and snaperoos
jbibla 8af4789
removed comments and made bech32 copied element absolute so it doesn'…
jbibla f8f9aba
lint
jbibla 785c417
snapshot fix
jbibla a51537c
Add new format to multisend tx
mariopino 0def73d
Update snap
mariopino 03fb1f9
Update src/scripts/transaction-utils.js
mariopino 9e6b44d
Add new design to all tx messages
mariopino c66d10f
Update snaps, cleanup, comment
mariopino 50030d9
Separate tx caption and tx type
mariopino a6b8241
Fix test, update snaps
mariopino 3c2c611
Update src/scripts/transaction-utils.js
mariopino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
[Added] [#3078](https://github.com/cosmos/lunie/issues/3078) Improve design of Activity page and support multisend transactions @mariopino |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know ob the object switch approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely more cleaner but as I need to make some comparisons for Withdrawal, Vote and Deposit types like:
} else if (this.transactionType.search('Voted') === 0) {
It's possible to do that in a dictionary?
Another option is just to simplify the caption for that messages and include the info in the tx detail, then we can use a dictionary. Maybe a better solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks funky to me. What are the options for
transactionType
that there are multiple withVoted
in it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I think you are on the right track. there should be an enum "transactionType" that should be different then the title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finally implemented that way. The icon name should be the caption string, so that way we don't need a dictionary, only need to handle
Update withdraw address
, which is the only specific case. A bit hacky but simplier :-)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still worried, that the transactionType is the title of the transaction. If we change the title now, we need to change the name of the icon. feels like an unnecessary linkage. But we can improve later.