Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/new app release flow #3188

Merged
merged 5 commits into from
Nov 27, 2019
Merged

Fabo/new app release flow #3188

merged 5 commits into from
Nov 27, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Nov 23, 2019

Bitrise now updates the version of the apps itself. Thanks for the tip @colw

Description:

Thank you! 🚀


For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

package.json Outdated
@@ -10,8 +10,8 @@
"lint": "vue-cli-service lint",
"lint:style": "vue-cli-service lint:style",
"release": "git checkout develop & git pull & git push origin develop:release",
"release:android": "git checkout develop && node ./tasks/bump-android-version.js && git commit android/app/build.gradle -m 'updated android app version' && git push origin develop:release-android",
"release:ios": "git checkout develop && node ./tasks/bump-ios-version.js && git commit ios/App/App/Info.plist -m 'updated ios app version' && git push origin develop:release-ios",
"release:android": "git checkout develop & git pull & git push origin develop:release-android",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbibla I think we should remove this completely. When there is a fix for mobile we just create a new release.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure! whatever you think is best!

@faboweb faboweb merged commit 0f8bea8 into develop Nov 27, 2019
@faboweb faboweb deleted the fabo/new-app-release-flow branch November 27, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants