Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jordan/deps #3192

Merged
merged 3 commits into from
Nov 27, 2019
Merged

Jordan/deps #3192

merged 3 commits into from
Nov 27, 2019

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Nov 24, 2019

Closes #ISSUE

Description:

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

faboweb
faboweb reviewed Nov 24, 2019
View reviewed changes
vue.config.js Show resolved Hide resolved
@jbibla
Copy link
Collaborator Author

jbibla commented Nov 25, 2019

we needed to upgrade cosmos-keys and cosmos-ledger, right?

@jbibla
Copy link
Collaborator Author

jbibla commented Nov 27, 2019

i haven't tested if the ledger actually works here yet.

@faboweb faboweb merged commit 46f6d38 into develop Nov 27, 2019
@faboweb faboweb deleted the jordan/deps branch November 27, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faboweb faboweb faboweb approved these changes

@colw colw Awaiting requested review from colw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbibla @colw @faboweb