-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ana/add no proposal history #3198
Conversation
</div> | ||
</div> | ||
<div v-else-if="!$apollo.loading && proposals.length > 0"> | ||
<div class="button-container"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The button is duplicated, can we pull it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
</div> | ||
<div slot="subtitle"> | ||
There are currently no governance proposals to display. | ||
Click the 'Create Proposal' button to submit the first proposal of the network! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click the 'Create Proposal' button to submit the first proposal of the network! | |
Click the 'Create Proposal' button to submit the first network proposal! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The language of Shakespeare and its mysteries...
@@ -1,56 +1,48 @@ | |||
<template> | |||
<PageContainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was PageContainer
doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was
PageContainer
doing?
It was intended to replace TmPage and some of the internals we don't need there anymore.
I assume we will still need TmPage to be present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so true. I think it should be like:
<TmPage
data-title="Proposals"
:managed="false">
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I am going to change it
Ok, now it should be good |
Oops, I missed the unit tests |
Codecov Report
@@ Coverage Diff @@
## develop #3198 +/- ##
========================================
Coverage 88.04% 88.04%
========================================
Files 126 126
Lines 1824 1824
Branches 275 275
========================================
Hits 1606 1606
Misses 211 211
Partials 7 7
|
</div> | ||
</div> | ||
<div v-else-if="!$apollo.loading && proposals.length > 0"> | ||
<TmDataLoading v-if="$apollo.loading" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this contradicts line 31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can move it up and use a v-else-if
</div> | ||
</div> | ||
<div v-else-if="!$apollo.loading && proposals.length > 0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div v-else-if="!$apollo.loading && proposals.length > 0"> | |
<div v-else> |
Closes #ISSUE
Description:
Integrating the Regen network into the frontend I noticed that there was an issue with the
PageProposals
component: the banner of "No Governance History" wouldn't be displayed, and the component would just stay blank, due to lack of proposals history.Luckily I fixed it by removing the
PageContainer
altogether.This is the screen as it was before the fix:
Thank you! 🚀
For contributor:
yarn changelog
for a guided process.Files changed
in the github PR explorerFor reviewer: