Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jordan/simpler code splitting and lazy loading #3207

Merged
merged 9 commits into from
Nov 28, 2019
Merged

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Nov 27, 2019

Closes #ISSUE

Description:

Thank you! 🚀


For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@jbibla
Copy link
Collaborator Author

jbibla commented Nov 27, 2019

with these changes:
Screen Shot 2019-11-26 at 7 48 41 PM

app.lunie.io:
Screen Shot 2019-11-26 at 7 48 51 PM

@faboweb
Copy link
Collaborator

faboweb commented Nov 27, 2019

This is now missing the lazy loading of the modals. But that's more complex I see. I will create a follow up issue.

@faboweb faboweb merged commit 8bac903 into develop Nov 28, 2019
@faboweb faboweb deleted the jordan/simple-perf branch November 28, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants