Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabo/fix ledger lib #3219

Merged
merged 3 commits into from
Nov 28, 2019
Merged

Fabo/fix ledger lib #3219

merged 3 commits into from
Nov 28, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Nov 28, 2019 •
edited
Loading

This updates the ledger library. The previous version had a bug in it. This version also supports the new Ledger Cosmos App v2

Description:

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@faboweb faboweb merged commit 81b9c65 into develop Nov 28, 2019
@faboweb faboweb deleted the fabo/fix-ledger-lib branch November 28, 2019 17:15
@jbibla
Copy link
Collaborator

jbibla commented Nov 28, 2019

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colw colw Awaiting requested review from colw

@jbibla jbibla Awaiting requested review from jbibla jbibla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faboweb @jbibla