Fabo/fix menu scrolling mobile #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i've seen PRs like this happen a bunch of times now - are we sure about this? |
jbibla
approved these changes
Nov 29, 2019
faboweb
added a commit
that referenced
this pull request
Nov 29, 2019
* fixed app menu scrolling up * changelog
|
It is working well for me. The only thing I see is, on the bottom, the Help/Feedback tab is overlapping the Privacy Policy link.
|
|
Wow, really huge screenshot O.o |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3172
Fixes the container of the menu on mobile so it doesn't scroll up
Description:
Thank you! 🚀
For contributor:
yarn changelogfor a guided process.Files changedin the github PR explorerFor reviewer: