Ana/fix rewards updating

[Bitcoinera]

Closes #3095

Description:

I am getting close to fix this issue: making the rewards update by themselves, without refreshing.
The most significant changes for this are found in the API side. I will now push that branch too.

Still I wonder if the reason why I am getting this error actually lies on the FE:

I believe so. I tried in the playground the API with the userRewardsIncremented subscription implemented and it worked quite well.

Thank you! 🚀

---

For contributor:

• Added changes entries. Run yarn changelog for a guided process.
• Reviewed Files changed in the github PR explorer
• Attach screenshots of the UI components on the PR description (if applicable)
• Scope of work approved for big PRs

For reviewer:

• Manually tested the changes on the UI

[codecov]

Codecov Report

Merging #3235 into develop will increase coverage by 0.01%.
The diff coverage is 37.5%.

@@             Coverage Diff             @@
##           develop    #3235      +/-   ##
===========================================
+ Coverage    88.85%   88.86%   +0.01%     
===========================================
  Files          125      125              
  Lines         1911     1913       +2     
  Branches       281      280       -1     
===========================================
+ Hits          1698     1700       +2     
  Misses         206      206              
  Partials         7        7

Impacted Files	Coverage Δ
src/components/staking/LiValidator.vue	83.33% <ø> (ø)	⬆️
src/components/common/TmBalance.vue	65% <0%> (-7.23%)	⬇️
src/components/staking/TableValidators.vue	72.41% <33.33%> (-4.51%)	⬇️
src/components/staking/PageValidator.vue	38.63% <66.66%> (+4.59%)	⬆️

[faboweb]

isn't this happening every block if the user has delegations?

[Bitcoinera]

not every block I think, but nearly yes

[Bitcoinera]

I am only missing the tests now, like I always do! 😅

[Bitcoinera]

Can somebody help me out testing the subscriptions? I just noticed they haven't been tested yet throughout the code.

🤣 🤣 🤣

[faboweb]

Why so complicated? There is a TableValidator already does fetch the rewards. Use the blocksubscription there once instead of on every LiValidator?

[faboweb]

Can somebody help me out testing the subscriptions? I just noticed they haven't been tested yet throughout the code.

You can just call the functions directly:
wrapper.vm.$apollo.$subscription.blockAdded.update(result)

[Bitcoinera]

Why so complicated? There is a TableValidator already does fetch the rewards. Use the blocksubscription there once instead of on every LiValidator?

Fixed! All updating logic now in TableValidators.