Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround to fix COSMOS REST api bug #3239

Merged
merged 4 commits into from
Dec 3, 2019

Conversation

mariopino
Copy link
Contributor

@mariopino mariopino commented Dec 3, 2019

Closes #3237

Description:

Workaround to fix wrong denom NDEFINED showed in Activity page in Staking and Restaking transactions.

Thank you! 🚀


For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #3239 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3239      +/-   ##
===========================================
+ Coverage    88.83%   88.85%   +0.01%     
===========================================
  Files          125      125              
  Lines         1908     1911       +3     
  Branches       291      292       +1     
===========================================
+ Hits          1695     1698       +3     
  Misses         206      206              
  Partials         7        7
Impacted Files Coverage Δ
src/scripts/transaction-utils.js 67.64% <100%> (+3.13%) ⬆️

@mariopino
Copy link
Contributor Author

Opened issue in cosmos-sdk repo:

cosmos/cosmos-sdk#5353

faboweb
faboweb previously approved these changes Dec 3, 2019
@mariopino mariopino self-assigned this Dec 3, 2019
@faboweb faboweb merged commit 532c6ca into develop Dec 3, 2019
@faboweb faboweb deleted the mario/3237-wrong-denom-unstake-workaround branch December 3, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong denom NDEFINED is showed in Activity page in Staking and Restaking transactions
2 participants