Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/feature flag url worng #3272

Merged
merged 5 commits into from
Dec 7, 2019
Merged

Fabo/feature flag url worng #3272

merged 5 commits into from
Dec 7, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Dec 7, 2019

Closes #ISSUE

Description:

Thank you! 🚀


For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Dec 7, 2019

Codecov Report

Merging #3272 into develop will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #3272      +/-   ##
==========================================
+ Coverage    90.61%   90.7%   +0.09%     
==========================================
  Files          126     126              
  Lines         1960    1958       -2     
  Branches       287     298      +11     
==========================================
  Hits          1776    1776              
+ Misses         179     177       -2     
  Partials         5       5
Impacted Files Coverage Δ
src/components/common/TmConnectedNetwork.vue 66.66% <0%> (+12.12%) ⬆️

@faboweb faboweb merged commit 4d57f2c into develop Dec 7, 2019
@faboweb faboweb deleted the fabo/ledger-errors-fix branch December 7, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant