-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ana/add back to validators button #3362
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
[Added] [#3362](https://github.com/cosmos/lunie/pull/3362) Adds "Back to Validators" button in PageValidator @Bitcoinera |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,13 +9,27 @@ | |
class="small" | ||
> | ||
<template v-if="validator.operatorAddress" slot="managed-body"> | ||
<div class="status-container"> | ||
<span :class="validator.status | toLower" class="validator-status"> | ||
{{ validator.status }} | ||
</span> | ||
<span v-if="validator.statusDetailed" class="validator-status-detailed"> | ||
{{ validator.statusDetailed }} | ||
</span> | ||
<button | ||
class="validators-list-button" | ||
color="secondary" | ||
@click="$router.push(`/validators`)" | ||
> | ||
<img src="/img/icons/arrow-icon.svg" /> | ||
<div style="width: 20px;display: inline-block"></div> | ||
Back to Validators | ||
</button> | ||
<div class="status-button-container"> | ||
<div class="status-container"> | ||
<span :class="validator.status | toLower" class="validator-status"> | ||
{{ validator.status }} | ||
</span> | ||
<span | ||
v-if="validator.statusDetailed" | ||
class="validator-status-detailed" | ||
> | ||
{{ validator.statusDetailed }} | ||
</span> | ||
</div> | ||
</div> | ||
<tr class="li-validator"> | ||
<td class="data-table__row__info"> | ||
|
@@ -389,6 +403,24 @@ export default { | |
} | ||
</script> | ||
<style scoped> | ||
.validators-list-button { | ||
margin: 0 0 20px 10px; | ||
width: 177px; | ||
height: 40px; | ||
background-color: #272b48; | ||
font-size: 14px; | ||
color: #7a88b8; | ||
border: 1px solid rgb(122, 136, 184, 0.1); | ||
border-radius: 5px; | ||
cursor: pointer; | ||
} | ||
|
||
.validators-list-button:hover { | ||
background: #445381; | ||
color: #f1f3f7; | ||
border-color: #445381; | ||
} | ||
|
||
.li-validator { | ||
display: flex; | ||
justify-content: space-between; | ||
|
@@ -478,8 +510,14 @@ span { | |
margin-top: 0.4rem; | ||
font-size: 0.8rem; | ||
} | ||
</style> | ||
<style> | ||
|
||
@media screen and (max-width: 425px) { | ||
.status-button-container { | ||
display: flex; | ||
flex-direction: column-reverse; | ||
} | ||
} | ||
|
||
@media screen and (max-width: 667px) { | ||
.button-container { | ||
width: 100%; | ||
|
@@ -490,4 +528,10 @@ span { | |
width: 50%; | ||
} | ||
} | ||
|
||
@media screen and (min-width: 1024px) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not a problem this time. but it is better to stick with either In this case we could have done:
|
||
.validators-list-button { | ||
display: none; | ||
} | ||
} | ||
</style> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bitcoinera @faboweb we already import material icons for this. we don't need to include separate svg's for this kind of stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Charlie seemed very happy with this arrow. I don't know 🤷♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. but we already import them as fonts - icons should be used like this (not imported as separate SVGs):
lunie/src/components/transactions/message-view/SendMessageDetails.vue
Line 24 in b9566b9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed: #3388