Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Intercom in mobile apps #3419

Merged
merged 5 commits into from
Jan 15, 2020
Merged

Enable Intercom in mobile apps #3419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
930e403
Mobile Intercom
mariopino Jan 14, 2020
1981010
changelog
mariopino Jan 14, 2020
4dbdb21
Cleanup, fix tests
mariopino Jan 14, 2020
ab489fd
Use emit
mariopino Jan 14, 2020
d4c6eb9
Use platform specific capacitor config files
mariopino Jan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/app/capacitor.build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ android {

apply from: "../capacitor-cordova-android-plugins/cordova.variables.gradle"
dependencies {

implementation project(':capacitor-intercom')

}

Expand Down
8 changes: 7 additions & 1 deletion android/app/src/main/assets/capacitor.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,11 @@
"appName": "Lunie",
"bundledWebRuntime": false,
"npmClient": "yarn",
"webDir": "dist"
"webDir": "dist",
"plugins": {
"IntercomPlugin": {
"android-apiKey": "android_sdk-xxxx",
"android-appId": "yyyy"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be null / empty string? probably doesn't matter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, before app building should be replaced by the correct values by the script Fabo coded yesterday.

}
}
}
3 changes: 3 additions & 0 deletions android/app/src/main/java/org/lunie/lunie/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

import java.util.ArrayList;

import io.stewan.capacitor.intercom.IntercomPlugin;

public class MainActivity extends BridgeActivity {
@Override
public void onCreate(Bundle savedInstanceState) {
Expand All @@ -16,6 +18,7 @@ public void onCreate(Bundle savedInstanceState) {
this.init(savedInstanceState, new ArrayList<Class<? extends Plugin>>() {{
// Additional plugins you've installed go here
// Ex: add(TotallyAwesomePlugin.class);
add(IntercomPlugin.class);
}});
}
}
3 changes: 3 additions & 0 deletions android/capacitor.settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// DO NOT EDIT THIS FILE! IT IS GENERATED EACH TIME "capacitor update" IS RUN
include ':capacitor-android'
project(':capacitor-android').projectDir = new File('../node_modules/@capacitor/android/capacitor')

include ':capacitor-intercom'
project(':capacitor-intercom').projectDir = new File('../node_modules/capacitor-intercom/android/capacitor-intercom')
1 change: 1 addition & 0 deletions changes/mario_3326-intercom-mobile-again
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[Fixed] [#3326](https://github.com/cosmos/lunie/issues/3326) Enable Intercom in mobile apps @mariopino
4 changes: 4 additions & 0 deletions ios/App/App/capacitor.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
"Keyboard": {
"resize": "none",
"style": "dark"
},
"IntercomPlugin": {
"ios-apiKey": "ios_sdk-xxxx",
"ios-appId": "yyyy"
}
}
}
Loading