Fabo/improve action modal #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3444 +/- ##
==========================================
+ Coverage 87.08% 87.1% +0.02%
==========================================
Files 124 124
Lines 2493 2497 +4
Branches 348 350 +2
==========================================
+ Hits 2171 2175 +4
Misses 315 315
Partials 7 7
|
Bitcoinera
reviewed
Jan 20, 2020
| min="0" | ||
| /> | ||
| <span class="input-suffix">{{ network.stakingDenom | viewDenom }}</span> | ||
| <TmField id="gas-price" v-model="gasPrice" step="0.000000001" type="number" min="0" /> |
There was a problem hiding this comment.
Did you change the linter rules?
There was a problem hiding this comment.
hmm no, we should have a look into standards. maybe my vs code is not working properly
|
I just checked and yes, this PR significantly improves the ActionModal behavior. So thumb up! 👍 |
Bitcoinera
approved these changes
Jan 21, 2020
|
awesome! all the linter changes are concerning but i'll merge anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modal would open and close when data is refetched