-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fabo/improve action modal #3444
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3444 +/- ##
==========================================
+ Coverage 87.08% 87.1% +0.02%
==========================================
Files 124 124
Lines 2493 2497 +4
Branches 348 350 +2
==========================================
+ Hits 2171 2175 +4
Misses 315 315
Partials 7 7
|
min="0" | ||
/> | ||
<span class="input-suffix">{{ network.stakingDenom | viewDenom }}</span> | ||
<TmField id="gas-price" v-model="gasPrice" step="0.000000001" type="number" min="0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you change the linter rules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm no, we should have a look into standards. maybe my vs code is not working properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
I just checked and yes, this PR significantly improves the ActionModal behavior. So thumb up! 👍 |
awesome! all the linter changes are concerning but i'll merge anyways. |
The modal would open and close when data is refetched