Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Balances" to "Wallet" #583

Merged
merged 2 commits into from
Mar 28, 2018
Merged

Rename "Balances" to "Wallet" #583

merged 2 commits into from
Mar 28, 2018

Conversation

mappum
Copy link
Contributor

@mappum mappum commented Mar 28, 2018

Thank you a lot for contributing to Cosmos Voyager!

Issue

closes: #516

Screenshots

❤️ Thank you!

@mappum mappum changed the title Rename Balances to Wallet Rename "Balances" to "Wallet" Mar 28, 2018
Copy link
Collaborator

@faboweb faboweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh tests are failing

@mappum
Copy link
Contributor Author

mappum commented Mar 28, 2018

Forgot to commit ./tests, fixed now 😄

@codecov
Copy link

codecov bot commented Mar 28, 2018

Codecov Report

Merging #583 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop     #583   +/-   ##
========================================
  Coverage    83.69%   83.69%           
========================================
  Files           87       87           
  Lines         1460     1460           
  Branches        67       67           
========================================
  Hits          1222     1222           
  Misses         226      226           
  Partials        12       12
Impacted Files Coverage Δ
app/src/renderer/routes.js 100% <ø> (ø) ⬆️
app/src/renderer/components/common/AppMenu.vue 57.14% <100%> (ø) ⬆️
app/src/renderer/components/wallet/PageWallet.vue 90% <100%> (ø)

@faboweb faboweb merged commit 9fabe71 into develop Mar 28, 2018
@faboweb faboweb deleted the matt/516-wallet-rename branch March 28, 2018 22:50
faboweb added a commit that referenced this pull request Jun 2, 2020
…mounts (#583)

* handle polkadot rewards amounts as bignumber

* hyper important fix. store previous era rewards

* enable polkadot

* fix polkador rewards amounts for real

* try fix store empty rewards

* fix rewards amounts decimals for real

* changelog

* changelog

* disable polkadot for production again

* oops

* Apply suggestions from code review

* linted

Co-authored-by: Fabian <frznhope@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "Balances" to "Wallet"
2 participants