Handle Node Sync in Block Explorer #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #587 +/- ##
===========================================
+ Coverage 84.84% 84.92% +0.08%
===========================================
Files 88 88
Lines 1471 1479 +8
Branches 67 67
===========================================
+ Hits 1248 1256 +8
Misses 211 211
Partials 12 12
|
faboweb
reviewed
Apr 1, 2018
| div(slot="subtitle") Please wait a moment. | ||
| </template> | ||
|
|
||
| <script> | ||
| import DataMsg from 'common/NiDataMsg' | ||
| export default { | ||
| name: 'ni-data-loading', | ||
| components: { DataMsg } | ||
| components: { DataMsg }, | ||
| props: { |
jbibla
reviewed
Apr 2, 2018
| state.subscription = false | ||
| commit('notifyError', { title: `Error subscribing to new blocks`, body: err.message }) | ||
| setTimeout(() => dispatch('subscribeToBlocks'), 30e3) |
There was a problem hiding this comment.
30e3? never seen that before. can't find anything on google about it.
There was a problem hiding this comment.
Scientific notation for 30000, maybe I should do 30 * 1000 so it's more obvious.
faboweb
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the block subscription to first check if the node is still syncing, and if so it waits another 30 seconds before trying again. If the node is syncing, a "Node is syncing blockchain..." dialog is shown in the explorer.
Issue
closes: #553
Screenshots
❤️ Thank you!