Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billy/764 flash white start #875

Merged
merged 3 commits into from
Jun 25, 2018
Merged

Billy/764 flash white start #875

merged 3 commits into from
Jun 25, 2018

Conversation

okwme
Copy link
Contributor

@okwme okwme commented Jun 25, 2018

Closes #764
(also closes #502)

Description: Theme styles weren't being applied before electron was launching. Show has beed set to false until the ready-to-show event has fired. Furthermore 300ms have been added for the icons font to load (at 250ms they were still not loaded). The mock electron app has been updated with the new event listener for tests.

Realized vue-resource was not being used even though included and causing the Critical dependency warning so it was removed as well : )

@codecov
Copy link

codecov bot commented Jun 25, 2018

Codecov Report

Merging #875 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #875   +/-   ##
========================================
  Coverage    89.37%   89.37%           
========================================
  Files           96       96           
  Lines         1723     1723           
  Branches        97       97           
========================================
  Hits          1540     1540           
  Misses         167      167           
  Partials        16       16
Impacted Files Coverage Δ
app/src/renderer/main.js 94.11% <ø> (ø) ⬆️
app/src/main/index.js 100% <ø> (ø) ⬆️

@faboweb faboweb merged commit 950cfb6 into develop Jun 25, 2018
@faboweb faboweb deleted the billy/764-flash-white-start branch June 25, 2018 13:22
faboweb pushed a commit that referenced this pull request Jun 6, 2020
* Add filter for cosmos based networks for slashing notifications

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants