Save full logs on Documents directory

lunij · Sep 3, 2024 · 6700167 · 6700167
1 parent 48a457b
commit 6700167
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 10 deletions.
diff --git a/Sources/Netbob/Core/LogFileProvider.swift b/Sources/Netbob/Core/LogFileProvider.swift
@@ -7,6 +7,7 @@ import UIKit
 
 protocol LogFileProviderProtocol {
     func createFullLog() throws -> URL
+    func saveFullLog() throws
     func createSingleLog(from connection: HTTPConnection, includeBody: Bool) throws -> URL
 }
 
@@ -27,16 +28,17 @@ class LogFileProvider: LogFileProviderProtocol {
     }
 
     func createFullLog() throws -> URL {
-        let fullLog = .logHeader +
-            httpConnectionRepository
-                .current
-                .map { $0.toString(includeBody: true) }
-                .joined(separator: "\n\n\n\(String(repeating: "-", count: 30))\n\n\n")
         let logFileUrl = fileManager.temporaryDirectory.appendingPathComponent("session.log")
-        try writeAction(fullLog, logFileUrl)
+        try writeAction(fullLogs, logFileUrl)
         return logFileUrl
     }
 
+    func saveFullLog() throws {
+        guard let documentsUrl = fileManager.urls(for: .documentDirectory, in: .userDomainMask).first else { return }
+        let logFileUrl = documentsUrl.appendingPathComponent("network-logs.txt")
+        try writeAction(fullLogs, logFileUrl)
+    }
+
     func createSingleLog(from connection: HTTPConnection, includeBody: Bool) throws -> URL {
         let string = .logHeader +
             connection.toString(includeBody: includeBody)
@@ -45,6 +47,15 @@ class LogFileProvider: LogFileProviderProtocol {
         try writeAction(string, logFileUrl)
         return logFileUrl
     }
+
+    // MARK: - Private
+
+    private var fullLogs: String {
+        .logHeader + httpConnectionRepository
+            .current
+            .map { $0.toString(includeBody: true) }
+            .joined(separator: "\n\n\n\(String(repeating: "-", count: 30))\n\n\n")
+    }
 }
 
 private func defaultWriteAction(string: String, url: URL) throws {

diff --git a/Sources/Netbob/Modules/List/ListViewState.swift b/Sources/Netbob/Modules/List/ListViewState.swift
@@ -55,7 +55,7 @@ final class ListViewState: ListViewStateAbstract {
 
     override func handleSaveAction() {
         do {
-            _ = try logFileProvider.createFullLog()
+            try logFileProvider.saveFullLog()
         } catch {
             Netbob.log(String(describing: error))
         }

diff --git a/Tests/NetbobTests/Core/LogFileProviderTests.swift b/Tests/NetbobTests/Core/LogFileProviderTests.swift
@@ -28,7 +28,7 @@ class LogFileProviderTests: XCTestCase {
         )
     }
 
-    func test_singleLog() throws {
+    func test_createSingleLog() throws {
         let url = try sut.createSingleLog(from: .fake(), includeBody: true)
 
         XCTAssertEqual(mockFileManager.calls, [])
@@ -37,12 +37,22 @@ class LogFileProviderTests: XCTestCase {
         XCTAssertEqual(writeActionURLs, ["tmp/single-connection.log"])
     }
 
-    func test_fullLog() throws {
+    func test_createFullLog() throws {
         let url = try sut.createFullLog()
 
         XCTAssertEqual(mockFileManager.calls, [])
         XCTAssertEqual(mockConnectionRepository.calls, [])
         XCTAssertEqual(url.absoluteString, "tmp/session.log")
         XCTAssertEqual(writeActionURLs, ["tmp/session.log"])
     }
+
+    func test_saveFullLog() throws {
+        mockFileManager.urlsReturnValue = [URL(string: "Documents")!]
+
+        try sut.saveFullLog()
+
+        XCTAssertEqual(mockFileManager.calls, [.urls])
+        XCTAssertEqual(mockConnectionRepository.calls, [])
+        XCTAssertEqual(writeActionURLs, ["Documents/network-logs.txt"])
+    }
 }
diff --git a/Tests/NetbobTests/Mocks/LogFileProviderMock.swift b/Tests/NetbobTests/Mocks/LogFileProviderMock.swift
@@ -8,6 +8,7 @@ import Foundation
 class LogFileProviderMock: LogFileProviderProtocol {
     enum Calls: Equatable {
         case createFullLog
+        case saveFullLog
         case createSingleLog(connection: HTTPConnection, includeBody: Bool)
     }
 
@@ -19,6 +20,10 @@ class LogFileProviderMock: LogFileProviderProtocol {
         return createFullLogReturnValue
     }
 
+    func saveFullLog() throws {
+        calls.append(.saveFullLog)
+    }
+
     var createSingleLogReturnValue = URL(string: "http://fake.fake")!
     func createSingleLog(from connection: HTTPConnection, includeBody: Bool) throws -> URL {
         calls.append(.createSingleLog(connection: connection, includeBody: includeBody))

diff --git a/Tests/NetbobTests/Modules/List/ListViewStateTests.swift b/Tests/NetbobTests/Modules/List/ListViewStateTests.swift
@@ -71,7 +71,7 @@ class ListViewStateTests: XCTestCase {
     func test_handleSaveAction() {
         sut.handleSaveAction()
 
-        XCTAssertEqual(mockLogFileProvider.calls, [.createFullLog])
+        XCTAssertEqual(mockLogFileProvider.calls, [.saveFullLog])
     }
 
     func test_createFullLog() {