Add OS version to snapshot name

lunij · Jun 14, 2024 · 6bd1fbc · 6bd1fbc
1 parent b4b161c
commit 6bd1fbc
Show file tree

Hide file tree

Showing 10 changed files with 12 additions and 4 deletions.
diff --git a/Tests/SnapshotTestingTests/SnapshotTestingTests.swift b/Tests/SnapshotTestingTests/SnapshotTestingTests.swift
@@ -197,8 +197,8 @@ final class SnapshotTestingTests: XCTestCase {
       button.bezelStyle = .rounded
       button.title = "Push Me"
       button.sizeToFit()
-      assertSnapshot(of: button, as: .image)
-      assertSnapshot(of: button, as: .recursiveDescription)
+      assertSnapshot(of: button, as: .image, named: "\(platform)\(osVersion.majorVersion)")
+      assertSnapshot(of: button, as: .recursiveDescription, named: "\(platform)\(osVersion.majorVersion)")
     }
 
     func testNSViewWithLayer() {
@@ -207,8 +207,8 @@ final class SnapshotTestingTests: XCTestCase {
       view.wantsLayer = true
       view.layer?.backgroundColor = NSColor.green.cgColor
       view.layer?.cornerRadius = 5
-      assertSnapshot(of: view, as: .image)
-      assertSnapshot(of: view, as: .recursiveDescription)
+      assertSnapshot(of: view, as: .image, named: "\(platform)\(osVersion.majorVersion)")
+      assertSnapshot(of: view, as: .recursiveDescription, named: "\(platform)\(osVersion.majorVersion)")
     }
   #endif
 

diff --git a/Tests/SnapshotTestingTests/TestHelpers.swift b/Tests/SnapshotTestingTests/TestHelpers.swift
@@ -2,6 +2,8 @@ import XCTest
 
 @testable import SnapshotTesting
 
+let osVersion = ProcessInfo.processInfo.operatingSystemVersion
+
 #if os(iOS)
   let platform = "ios"
 #elseif os(tvOS)

diff --git a/.../SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testNSView.macos13.png b/.../SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testNSView.macos13.png
diff --git a/Tests/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testNSView.macos13.txt b/Tests/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testNSView.macos13.txt
@@ -0,0 +1,4 @@
+[   AF    ! wLU ] h=--- v=--- NSButton "Push Me" f=(0,0,84,32) b=(-) => <_NSViewBackingLayer>
+  [   A     ! wLU ] h=--- v=--- NSButtonBezelView f=(0,0,84,32) b=(-) => <_NSViewBackingLayer>
+  [   AF    ! wLU ] h=--- v=--- NSButtonTextField "Push Me" f=(11,7,62,15) b=(-) => <NSTextLayer>
+A=autoresizesSubviews, C=canDrawConcurrently, D=needsDisplay, F=flipped, G=gstate, H=hidden (h=by ancestor), L=needsLayout (l=child needsLayout), U=needsUpdateConstraints (u=child needsUpdateConstraints), O=opaque, P=preservesContentDuringLiveResize, S=scaled/rotated, W=wantsLayer (w=ancestor wantsLayer), V=needsVibrancy (v=allowsVibrancy), #=has surface
diff --git a/...s__/SnapshotTestingTests/testNSView.1.png → ...apshotTestingTests/testNSView.macos14.png b/...s__/SnapshotTestingTests/testNSView.1.png → ...apshotTestingTests/testNSView.macos14.png
diff --git a/...s__/SnapshotTestingTests/testNSView.2.txt → ...apshotTestingTests/testNSView.macos14.txt b/...s__/SnapshotTestingTests/testNSView.2.txt → ...apshotTestingTests/testNSView.macos14.txt
diff --git a/...TestingTests/__Snapshots__/SnapshotTestingTests/testNSViewWithLayer.macos13.png b/...TestingTests/__Snapshots__/SnapshotTestingTests/testNSViewWithLayer.macos13.png
diff --git a/...s/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testNSViewWithLayer.macos13.txt b/...s/SnapshotTestingTests/__Snapshots__/SnapshotTestingTests/testNSViewWithLayer.macos13.txt
@@ -0,0 +1,2 @@
+[   A     ! W U ] h=--- v=--- NSView f=(0,0,10,10) b=(-) => <_NSViewBackingLayer>
+A=autoresizesSubviews, C=canDrawConcurrently, D=needsDisplay, F=flipped, G=gstate, H=hidden (h=by ancestor), L=needsLayout (l=child needsLayout), U=needsUpdateConstraints (u=child needsUpdateConstraints), O=opaque, P=preservesContentDuringLiveResize, S=scaled/rotated, W=wantsLayer (w=ancestor wantsLayer), V=needsVibrancy (v=allowsVibrancy), #=has surface
diff --git a/...hotTestingTests/testNSViewWithLayer.1.png → ...tingTests/testNSViewWithLayer.macos14.png b/...hotTestingTests/testNSViewWithLayer.1.png → ...tingTests/testNSViewWithLayer.macos14.png
diff --git a/...hotTestingTests/testNSViewWithLayer.2.txt → ...tingTests/testNSViewWithLayer.macos14.txt b/...hotTestingTests/testNSViewWithLayer.2.txt → ...tingTests/testNSViewWithLayer.macos14.txt