Do not try to translate classes in META-INF/versions #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a multirelease-jar environment, there could be classes under META-INF/versions, which retrolambda would try to translate. As per definition, these are Java classes newer than Java 1.8, so they shouldn't be processed at all, especially since it is expected that there is at least some version (hopefully 1.8 or older) of that class in the path that is not prefixed by META-INF/versions. Extend FilteringFileVisitor to never visit /META-INF/versions, and modify FilteringFileVisitor so it's usable in all cases, even when no other filtering is required.
kohlschuetter
force-pushed
the
ck/FilteringFileVisitor
branch
from
328d578
to
2abb948
Compare
|
Requires a test case to reproduce whatever was the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a multirelease-jar environment, there could be classes under META-INF/versions, which retrolambda would try to translate.
As per definition, these are Java classes newer than Java 1.8, so they shouldn't be processed at all, especially since it is expected that there is at least some version (hopefully 1.8 or older) of that class in the path that is not prefixed by META-INF/versions.
Extend FilteringFileVisitor to never visit /META-INF/versions, and modify FilteringFileVisitor so it's usable in all cases, even when no other filtering is required.