Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to udp multicast join tests #543

Merged
merged 1 commit into from
May 10, 2021

Conversation

squeek502
Copy link
Member

@squeek502 squeek502 commented May 8, 2021

This is one way to close #539. See #539 (comment) for a bit more context.

With the default settings of firewalld (used by Fedora, RHEL, etc), incoming messages from multicast IPs are dropped, meaning that the multicast test will hang forever. This PR introduces a 1 second timeout, after which the test will fail.

When the tests timeout, it'll look something like:

  timeout (could be caused by firewall settings)
  .\lib/tap.lua:66: Found 1 unexpected call
  stack traceback:
        [C]: in function 'error'
        .\lib/tap.lua:66: in function <.\lib/tap.lua:48>
        [C]: in function 'xpcall'
        .\lib/tap.lua:48: in function 'run'
        .\lib/tap.lua:146: in function <.\lib/tap.lua:122>
        [C]: at 0x7ff7494359f0
not ok 6 udp multicast join ipv4
  timeout (could be caused by firewall settings)
  .\lib/tap.lua:66: Found 1 unexpected call
  stack traceback:
        [C]: in function 'error'
        .\lib/tap.lua:66: in function <.\lib/tap.lua:48>
        [C]: in function 'xpcall'
        .\lib/tap.lua:48: in function 'run'
        .\lib/tap.lua:146: in function <.\lib/tap.lua:122>
        [C]: at 0x7ff7494359f0
not ok 7 udp multicast join ipv6

This is one way to close luvit#539.

With the default settings of firewalld (used by Fedora, RHEL, etc), incoming messages from multicast IPs are dropped, meaning that the multicast test will hang forever. This introduces a 1 second timeout, after which the test will fail.
@squeek502 squeek502 merged commit f23ff47 into luvit:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing lua luv tests in build environments
2 participants