Add json field #31
Merged
Add json field #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Sep 23, 2020
| @@ -7,6 +7,9 @@ const sns = new AWS.SNS({ | |||
| region: process.env.AWS_SNS_REGION | |||
| }); | |||
|
|
|||
| // Amazon SNS currently allows a maximum size of 256 KB for published messages. | |||
| const MAX_EVENT_MESSAGE_SIZE = 256 * 1024; | |||
There was a problem hiding this comment.
it's 256 kilobyte limitation, so MAX_EVENT_MESSAGE_SIZE means the maximum bytes we can have
index.js
Outdated
| @@ -115,6 +134,13 @@ function dispatch({ type, uri, id, checksum, source, message }) { | |||
| throw new InvalidEventMessageError("event message is required"); | |||
| } | |||
|
|
|||
| let JsonStr; | |||
There was a problem hiding this comment.
maybe lowercase jsonStr because it is not a class
There was a problem hiding this comment.
thanks for the pick up, fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recordsfor S3 eventsjsonfield, when publish message it will be stringified, then parsed back to json when consume the messagejsonfiled is too large