Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types from public offer #29

Merged
merged 5 commits into from
Jul 19, 2021
Merged

Add types from public offer #29

merged 5 commits into from
Jul 19, 2021

Conversation

keithbro
Copy link

@keithbro keithbro commented Jul 19, 2021 •
edited
Loading

Adds the types that @zediah kindly added to Public Offer. We'd now like to use them in the Admin Portal.

  • Update CI/CI to publish master for new versions
  • Bump mocha to v6 (to remove yarn audit warning)

@keithbro keithbro requested review from zediah and corbpaul July 19, 2021 00:32
zediah
zediah approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@zediah zediah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really work without having to make any mention of typescript in the project itself? 🤔

@keithbro
Copy link
Author

Does this really work without having to make any mention of typescript in the project itself? 🤔

I think

  "types": "index.d.ts",

Is all you need.

I used this branch locally from admin portal and got the types so I think it's good.

@keithbro keithbro merged commit 4cc3cb2 into master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zediah zediah zediah approved these changes

@corbpaul corbpaul Awaiting requested review from corbpaul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithbro @zediah