Add similarity as default action #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
caitlynachen
commented
Nov 27, 2020
caitlynachen
commented
added 2 commits
November 27, 2020 14:53
|
Related to #36 |
dorisjlee
reviewed
Nov 29, 2020
dorisjlee
requested changes
Nov 29, 2020
|
Thanks @caitlynachen, could we add a few tests inside test_action.py that validates that similarity is working correctly? (e.g., checks that the top k items are in fact the most similar ones.) |
added 2 commits
December 4, 2020 15:31
|
@caitlynachen: Could you fix the failing test on this before we review the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.