Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ISP 3A camera controls #52

Merged
merged 8 commits into from
Oct 7, 2020
Merged

Add ISP 3A camera controls #52

merged 8 commits into from
Oct 7, 2020

Conversation

alex-luxonis
Copy link
Collaborator

@alex-luxonis alex-luxonis commented Sep 28, 2020 •
edited
Loading

@alex-luxonis alex-luxonis mentioned this pull request Sep 28, 2020
Merged
SzabolcsGergely
SzabolcsGergely approved these changes Sep 28, 2020
View reviewed changes
Copy link
Collaborator

@SzabolcsGergely SzabolcsGergely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please resolve other PR's first.

@alex-luxonis alex-luxonis force-pushed the isp_3a_controls_develop branch from 60a8dce to c7e197f Compare October 5, 2020 21:45
@alex-luxonis alex-luxonis requested a review from themarpe October 7, 2020 14:27
themarpe
themarpe requested changes Oct 7, 2020
View reviewed changes
Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the changes, the way to access these enums will be equivalent between C++ and Python

Instead of: PY: Isp3a.CMD_START_STREAM and C++ CameraControl::Command::START_STREAM

Python side becomes: CameraControl.Command.START_STREAM as well

src/device_bindings.cpp Outdated Show resolved Hide resolved
src/device_bindings.cpp Outdated Show resolved Hide resolved
src/device_bindings.cpp Outdated Show resolved Hide resolved
src/device_bindings.cpp Outdated Show resolved Hide resolved
@alex-luxonis
Address review comments:
78f0f40 
rename and move CamId/Command to CameraControl class
@alex-luxonis alex-luxonis merged commit 70d2d9b into develop Oct 7, 2020
@alex-luxonis alex-luxonis deleted the isp_3a_controls_develop branch October 7, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themarpe themarpe themarpe requested changes

@SzabolcsGergely SzabolcsGergely SzabolcsGergely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-luxonis @themarpe @SzabolcsGergely