Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor logging in SDK #1135

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Refactor logging in SDK #1135

merged 1 commit into from
Dec 8, 2023

Conversation

hexbabe
Copy link

@hexbabe hexbabe commented Nov 6, 2023 •
edited
Loading

Resolves #1132

Erol444
Erol444 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@Erol444 Erol444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hexbabe
Copy link
Author

hexbabe commented Nov 7, 2023

Cool! What is the release cycle of the DepthAI SDK, so I can look out for changes and update my dependency version @Erol444

@hexbabe
Copy link
Author

hexbabe commented Dec 7, 2023

Hi @Erol444, sorry to bump you again, could you let us know when this change can be merged? Looks like CI is failing because of Docker creds?

@Erol444 Erol444 merged commit e1c1f58 into luxonis:main Dec 8, 2023
2 of 3 checks passed
@Erol444
Copy link
Member

Erol444 commented Dec 8, 2023

Just merged it, so it should get added to the next release of the SDK :)

@hexbabe
Copy link
Author

hexbabe commented Jan 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erol444 Erol444 Erol444 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature-Request] Implement best practice for Python logging
2 participants
@hexbabe @Erol444