CMake: developer experience improvements #297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bump cmake minimum version to 3.13 and make it possible to use CMP0077: https://cmake.org/cmake/help/git-stage/policy/CMP0077.html * starting with cmake 3.13 the behaviour of option() changed so that any value already set is preserved when the option() statement is reached. Signed-off-by: António Oliveira <antonio.oliveira@konsulko.com>
* the install() statement copies all *.h files from the top level dir of the current project, instead of only the lv_drivers headers. This appears to be a typo, as the actual variable that makes sense to refer to the headers in the lv_drivers project files is CMAKE_CURRENT_SOURCE_DIR, so I changed it. * Without this change, calling install on a project which bundles lv_drivers within its source tree, would copy every single .h file in the whole project, which can be nasty, especially with large codebases. Signed-off-by: António Oliveira <antonio.oliveira@konsulko.com>
* added the option to set lv_drivers as bundled. If enabled, the install targets are not defined and no lv_drivers headers or objects will be installed, since lv_drivers will be directly linked to any of its dependants. * the default behaviour is preserved. Signed-off-by: António Oliveira <antonio.oliveira@konsulko.com>
* if lv_drivers is used with: #define USE_SDL 1 The CMake option LV_DRIVERS_USE_SDL may be set to automatically find libsdl2 and add it to the list of link libraries Signed-off-by: António Oliveira <antonio.oliveira@konsulko.com>
amsobr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some improvements related to developer experience.
The bump to CMake v3.13 enables CMake policy #CMP0077, which makes it easier to define and use configuration variables, especially when bundling lv_drivers from another project.
Other improvements include:
Please feel free to considers these changes as you see fit.
Thanks,
António