refactor(display): add API to set raw buffer to display #5274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The drivers have been changed back original logic. Fix lvgl#5270 Related to lvgl#5204 lvgl/lv_binding_micropython#313 Discussion on lvgl#5273 Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
|
I have introduced new API @kisvegabor Please check if it's suitable. The micropython CI failed and i'm looking into it. |
kisvegabor
reviewed
Jan 11, 2024
|
For the MicroPython CI, probably this needs to be updated: https://github.com/lvgl/lvgl/blob/master/tests/micropy_test/micropy.py#L88 |
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
|
CI should pass now. I missed one driver change in lv_linux_fbdev.c |
kisvegabor
reviewed
Jan 11, 2024
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
XuNeo
force-pushed
the
add-display-raw-buffer-api
branch
from
6d72525
to
f3e0106
Compare
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
|
Ah, Thank your this PR! |
kisvegabor
approved these changes
Jan 11, 2024
PGNetHun
reviewed
Jan 11, 2024
|
Thx for this PR, I will update MicroPython display drivers to use it in the MicroPython - LVGL v9 update PR |
lion2tomato
pushed a commit
to lion2tomato/lvgl
that referenced
this pull request
Mar 19, 2024
VELAPLATFO-20122 The drivers have been changed back original logic. Fix lvgl#5270 Fix lvgl#5271 Related to lvgl#5204 lvgl/lv_binding_micropython#313 Discussion on lvgl#5273 Change-Id: I798af8753f50ba0eed9d6b7f00e184fb032bde1c Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help us review this PR! Anyone can approve it or request changes.
Description of the feature or fix
The drivers have been changed back original logic. Fix #5270 Fix #5271
Related to #5204 lvgl/lv_binding_micropython#313
Discussion on #5273
lv_display_set_raw_buffersis kept.Checkpoints
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle needs to be installed) and follow the Code Conventions