Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Bridgecraft is not working with Xcode 10, so here is a PR to make it compatible.
Basically the problem is that the new build system, the default one in Xcode 10, doesn't support
-dry-run
yet, so in order to Bridgecraft to work, it must explicitly use the legacy build system.Once the new build system supports
-dry-run
, the flag-UseModernBuildSystem=0
can be removed.I also replaced
-n
with-dry-run
, because the error that was outputted waserror: -dry-run is not yet supported in the new build system
, but I couldn't find that option anywhere, until after a lot of trial error, I discovered that-n
and-dry-run
are the same, maybe-n
it's just the abbreviation, so I made it explicitly.I added pin versions to Carthage, to make sure that Carthage and Swift Package Manager dependencies versions match.
NOTE: This is not related itself with the PR, but there are some dependencies that are not it compatible with Swift 4.2, and Xcode 10 can't build Bridgecraft, so in order to create the next release, you will need to use Xcode 9. This also applies when updating Carthage.
If you have any question please let me know.