Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xcode 10 compatibility #15

Merged
merged 4 commits into from
Sep 25, 2018
Merged

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented Sep 25, 2018

Hello, Bridgecraft is not working with Xcode 10, so here is a PR to make it compatible.

Basically the problem is that the new build system, the default one in Xcode 10, doesn't support -dry-run yet, so in order to Bridgecraft to work, it must explicitly use the legacy build system.

Once the new build system supports -dry-run, the flag -UseModernBuildSystem=0 can be removed.

I also replaced -n with -dry-run, because the error that was outputted was error: -dry-run is not yet supported in the new build system, but I couldn't find that option anywhere, until after a lot of trial error, I discovered that -n and -dry-run are the same, maybe -n it's just the abbreviation, so I made it explicitly.

I added pin versions to Carthage, to make sure that Carthage and Swift Package Manager dependencies versions match.

NOTE: This is not related itself with the PR, but there are some dependencies that are not it compatible with Swift 4.2, and Xcode 10 can't build Bridgecraft, so in order to create the next release, you will need to use Xcode 9. This also applies when updating Carthage.

If you have any question please let me know.

@lvsti
Copy link
Owner

lvsti commented Sep 25, 2018

Hey, thanks for the fixes, I appreciate it! I didn't manage to compile the project due to some errors in XcodeEditor so I unearthed an old branch of mine where I replaced it with XcodeEdit which, unlike XcodeEditor, is still being developed.

@lvsti
Copy link
Owner

lvsti commented Sep 25, 2018

well it still doesn't compile on my machine with the new toolchain because Carthage cannot build the Yams dependency... 😠

fatal error: Unexpected Swift version: file /tmp/swiftlint-20170407-45056-wip7rd/Source/SwiftLintFramework/Models/SwiftVersion.swift, line 38

@lvsti
Copy link
Owner

lvsti commented Sep 25, 2018

nevermind, updating swiftlint solved it

@lvsti lvsti merged commit 4df8cbd into lvsti:master Sep 25, 2018
@4brunu 4brunu deleted the add_xcode_10_compability branch September 26, 2018 10:50
@4brunu
Copy link
Contributor Author

4brunu commented Sep 26, 2018

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants