Adjust for new asset naming scheme #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
When the download failed, we should not just go on trying to un-tar a 404 error page. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The name of the `.tar` file is repeated multiple times, verbatim. This not only violates the Don't Repeat Yourself (DRY) principle, it also makes it easier to miss an instance when the file name changes (as it did with lycheeverse/lychee#1464). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Until version 0.15.1, the naming scheme of the release assets let them start with `lychee-<version>-`. This is no longer the case as of lycheeverse/lychee#1464, though, breaking the `lychee-action`. Since we need to allow using older versions, still, we are now stuck with a really ugly `case` construct, but this is still far better than having a broken GitHub Action. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
mre
reviewed
Aug 20, 2024
|
This looks good. Just to document the behavior for future me, from what I can see, this change covers all four cases:
Thanks for the fix @dscho! |
dscho
added a commit
to dscho/git-scm.com
that referenced
this pull request
Aug 28, 2024
As of lycheeverse/lychee-action#234, the default branch of https://github.com/lycheeverse/lychee-action has the fix and I do not need to refer to a commit that is reachable only in my own fork. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #1464, the naming scheme of the release assets has changed, breaking this here GitHub Action. Currently, this can only be seen with the
nightlyvariant, but future releases oflycheewill see more severe breakages without this PR or something similar.