fix: Remove tokio console subscriber (#1524)

The console subscriber is the source of quite a few papercuts like
#1513.

Since we don't use it at the moment, I decided to remove it.

.github/workflows/ci.yml

@@ -15,8 +15,7 @@ on:
 env:
   CARGO_TERM_COLOR: always
   CARGO_INCREMENTAL: 0
-  # tokio_unstable is needed for tokio-console
-  RUSTFLAGS: -D warnings --cfg tokio_unstable
+  RUSTFLAGS: -D warnings
 
 jobs:
   test:

README.md

@@ -663,30 +663,6 @@ Try one of these links to get started:
 
 For more detailed instructions, head over to [`CONTRIBUTING.md`](/CONTRIBUTING.md).
 
-## Debugging and improving async code
-
-Lychee makes heavy use of async code to be resource-friendly while still being
-performant. Async code can be difficult to troubleshoot with most tools,
-however. Therefore we provide experimental support for
-[tokio-console](https://github.com/tokio-rs/console). It provides a top(1)-like
-overview for async tasks!
-
-If you want to give it a spin, download and start the console:
-
-```sh
-git clone https://github.com/tokio-rs/console
-cd console
-cargo run
-```
-
-Then run lychee with some special flags and features enabled.
-
-```sh
-RUSTFLAGS="--cfg tokio_unstable" cargo run --features tokio-console -- <input1> <input2> ...
-```
-
-If you find a way to make lychee faster, please do reach out.
-
 ## Troubleshooting and Workarounds
 
 We collect a list of common workarounds for various websites in our [troubleshooting guide](./docs/TROUBLESHOOTING.md).

lychee-bin/Cargo.toml

@@ -68,18 +68,7 @@ tracing-subscriber = { version = "0.3.18", default-features = false, features =
 uuid = { version = "1.10.0", features = ["v4"] }
 wiremock = "0.6.2"
 
-[dependencies.console-subscriber]
-version = "0.4.0"
-optional = true
-
-[dependencies.tracing-subscriber]
-version = "0.3.18"
-default-features = false
-features = ["fmt", "env-filter"]
-optional = true
-
 [features]
-tokio-console = ["dep:console-subscriber", "dep:tracing-subscriber"]
 
 # Compile and statically link a copy of OpenSSL.
 vendored-openssl = ["openssl-sys/vendored"]
@@ -110,4 +99,4 @@ required-features = ["check_example_domains"]
 [package.metadata.binstall]
 pkg-url = "{ repo }/releases/download/v{ version }/{ name }-v{ version }-{ target }{ archive-suffix }"
 bin-dir = "{ bin }{ binary-ext }"
-pkg-fmt = "tgz"
+pkg-fmt = "tgz"

lychee-bin/src/main.rs

@@ -115,9 +115,6 @@ enum ExitCode {
 const LYCHEEIGNORE_COMMENT_MARKER: &str = "#";
 
 fn main() -> Result<()> {
-    #[cfg(feature = "tokio-console")]
-    console_subscriber::init();
-
     // std::process::exit doesn't guarantee that all destructors will be run,
     // therefore we wrap the main code in another function to ensure that.
     // See: https://doc.rust-lang.org/stable/std/process/fn.exit.html