Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore casing when processing markdown fragments + check for percent encoded ancors #1535

Merged
merged 6 commits into from
Oct 28, 2024
Merged

Ignore casing when processing markdown fragments + check for percent encoded ancors #1535

merged 6 commits into from
Oct 28, 2024

Conversation

autoantwort
Copy link
Contributor

@autoantwort autoantwort commented Oct 18, 2024 •
edited
Loading

Fixes #1534 and #1467

@autoantwort autoantwort changed the title Ignore casing when processing markdown fragments Ignore casing when processing markdown fragments + check for percent encoded ancors Oct 18, 2024
@mre
Copy link
Member

mre commented Oct 26, 2024

The lint issue should be fixed in master now, so you can rebase to get rid of that. Not sure about the failing test. Is there still a problem with the implementation, or do you just have to update the total link count in the failing test?

@autoantwort autoantwort force-pushed the feature/markdown-fragment-casing branch from d5293d1 to ad3fc83 Compare October 26, 2024 19:38
@autoantwort
Copy link
Contributor Author

or do you just have to update the total link count in the failing test?

Yeah that was it

mre
mre approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@mre mre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the improvement!

@mre mre merged commit 9801590 into lycheeverse:master Oct 28, 2024
7 checks passed
@mre mre mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mre mre mre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with upper case umlauts in fragments
2 participants
@autoantwort @mre