Refactor cache handling test to make it more robust #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mre
force-pushed
the
bugfix/cache-test-robustness
branch
from
04a5258
to
4ad08fb
Compare
mre
force-pushed
the
bugfix/cache-test-robustness
branch
from
4ad08fb
to
ad1c84f
Compare
|
@dmathieu, this should make the cache check a bit more robust. We're improving the test setup and cleanup process, as well as ensuring a clean state before running tests. The most important changes include adding a delay to ensure file operations complete and improving file handling for test consistency. Here's hoping that this will deal with the flakiness. |
mre
changed the title
Merged
mre
added a commit
that referenced
this pull request
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a refactoring of the cache handling test to make it more robust. The cache handling test now ensures a clean state before running.